Skip to content

TEST/UCP/DEVICE: Fix device API test wireup #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

TEST/UCP/DEVICE: Fix device API test wireup #10938

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
220cc91
TEST/UCP/DEVICE: Fix device API test wireup
michal-shalev Oct 7, 2025
191803f
TEST/UCP/DEVICE: Use flush_ep() to ensure endpoint wireup
michal-shalev Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions test/gtest/ucp/test_ucp_device.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,8 @@ void test_ucp_device::init()
receiver().connect(&sender(), get_ep_params());
}

ucp_device_mem_list_handle_h handle;
while (ucp_device_mem_list_create(sender().ep(), NULL, &handle) ==
UCS_ERR_NOT_CONNECTED) {
progress();
}
/* Flush to ensure endpoint wireup is complete before device API usage */
flush_ep(sender());
Copy link
Contributor

@tvegas1 tvegas1 Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think flush can return ok even when connection has not happened, so if we use flush, we should probably send first a dummy request.

}

test_ucp_device::mem_list::mem_list(entity &sender, entity &receiver,
Expand Down
Loading