-
Notifications
You must be signed in to change notification settings - Fork 124
API: add float128 and float32(64,128)_complex dt #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
128cba3 to
80f7bd6
Compare
|
@samnordmann It might be better to decouple the formatting changes from the functional changes. |
jladd-mlnx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Way too many white-space changes. I had to hide whitespaces in order to make sense of the PR.
-
The file
src/ucc/api/ucc.his Whitespace-only changes. -
Should we include support for complex half precision? Does HPL AI use it?
typedef enum cudaDataType_t
{
CUDA_R_16F= 2, // 16 bit real
CUDA_C_16F= 6, // 16 bit complex
CUDA_R_32F= 0, // 32 bit real
CUDA_C_32F= 4, // 32 bit complex
CUDA_R_64F= 1, // 64 bit real
CUDA_C_64F= 5, // 64 bit complex
CUDA_R_8I= 3, // 8 bit real as a signed integer
CUDA_C_8I= 7, // 8 bit complex as a pair of signed integers
CUDA_R_8U= 8, // 8 bit real as a signed integer
CUDA_C_8U= 9 // 8 bit complex as a pair of signed integers
} cudaDataType;
8b42a71 to
20d60a8
Compare
The formatting changes were due to a mistake with automatic formatting. It is fixed now. |
cd992f2 to
9bed721
Compare
db2ae78 to
3a5f501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this PR, but there are SHARP_DTYPE_UINT8 and SHARP_DTYPE_UINT8 defined in sharp.h, should we update mapping? cc @bureddy
6ee4591 to
4b54615
Compare
|
bot:retest |
2cb6da8 to
50ae438
Compare
vspetrov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samnordmann plz address final set of minor changes
* API: add float128 and float32(64,128)_complex dt * TEST: update mpi_tests with new dt * TEST: update Gtest with new dt * BUILD: check dt size during preprocessing
* API: add float128 and float32(64,128)_complex dt * TEST: update mpi_tests with new dt * TEST: update Gtest with new dt * BUILD: check dt size during preprocessing
What
Add support for four new datatypes: float128, float32_complex, float64_complex, float128_complex.