This repository has been archived by the owner on May 23, 2023. It is now read-only.
add tracer close #147
Open
add tracer close #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
suggested changes
May 21, 2020
There was a problem hiding this comment.
Nothing prevents concrete implementations from having a Close method. But OpenTracing Specification never dictated that Close must exist at the API level. A PR is not how we make changes to the OT API - the change must be proposed at specification first, which was in fact discussed many times without conclusion that such method must exist.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==== JS stack trace =========================================
0: ExitFrame [pc: 0x55f7a153eef9]
Security context: 0x26f2f4a808a1
1: /* anonymous */ [0x225ce0ec43c1] ..........client/dist/src/reporters/remote_reporter.js:~66] pc=0x530c1d0d7cc
2: listOnTimeout(aka listOnTimeout) [0x1089c7033d69] [internal/timers.js:~480] [pc=0x530c210d12d](this=0x0f1cd8bc04a9 ,...
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
How can I push code?