Add ability to unwrap ResponseWriter set by Middleware #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpuncel
force-pushed
the
mpuncel/unwrap-response-writer
branch
from
5fe6a3d
to
89669d3
Compare
When wrapping an HTTP server with Middleware(), HTTP handlers lose the ability to cast their ResponseWriter argument to any of the optional interfaces like http.Flusher or http.Hijacker. This commit adds an optional interface ResponseWriterWrapper which has a method for unwrapping the ResponseWriter installed by Middleware. Existing handlers can then test for implementation of this interface and do an unwrap if the conversion succeeds, and then use whatever underlying optional http interfaces were previously accessible. Addresses opentracing-contrib#34
mpuncel
force-pushed
the
mpuncel/unwrap-response-writer
branch
from
89669d3
to
ee969ee
Compare
|
I'm realizing the approach here might not be sufficient for many use cases, for instance if the type assertions happen in third party code. |
|
I am not sure how this would help. The various standard interfaces that a writer can implement are often checked by 3rd party libraries, which would have no knowledge of this extra unwrap method. |
|
yep, will close. I think an approach like https://github.com/felixge/httpsnoop would be better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When wrapping an HTTP server with Middleware(), HTTP handlers lose the
ability to cast their ResponseWriter argument to any of the optional
interfaces like http.Flusher or http.Hijacker. This commit adds an
optional interface ResponseWriterWrapper which has a method for
unwrapping the ResponseWriter installed by Middleware.
Existing handlers can then test for implementation of this interface and
do an unwrap if the conversion succeeds, and then use whatever
underlying optional http interfaces were previously accessible.
Addresses #34