Action v0.0.1 #2

kislerdm · 2023-10-04T23:21:36Z

Resolves opentofu/opentofu#556

What changed

Added a port of the setup-terraform action. Note that the dependency hashicorp/js-releases was swapped with the adapter defined in lib/releases.js.

Why do we need it

To facilitate tofu adoption and integration into github CI pipelines

cc: @eranelbaz @cube2222

Signed-off-by: Dmitry Kisler <[email protected]>

…nition. Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

CODE_OF_CONDUCT.md

eranelbaz

I basically have a lot of questions
but I think it looks good

.github/workflows/setup-tofu.yml

dist/index.js

lib/setup-tofu.js

package.json

README.md

CHANGELOG.md

index.js

lib/setup-tofu.js

action.yml

.github/workflows/data/local/main.tf

.github/workflows/continuous-integration.yml

.github/workflows/setup-tofu.yml

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

details: - opentofu#2 (comment) - opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

…matrix - tofu-wrapper flag. chore: adjusted version selection test selection. Signed-off-by: Dmitry Kisler <[email protected]>

…t tests. Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

Yantrio

Overall it looks good, but I think this needs some cleaning up.

.github/workflows/continuous-integration.yml

.github/workflows/setup-tofu.yml

.gitignore

lib/releases.js

lib/setup-tofu.js

kislerdm · 2023-10-12T09:20:50Z

@Yantrio Hey James! Thanks a lot for your review - I'll go through your comments thoroughly later today if you don't mind. A summarized reply to many of them: big part of the codebase was copied from setup-terraform without modification, hence the status quo may create some confusion and lead to the comments like "what year is it" 😀

I'll implement your suggestions, however we could also iteratively refactor after releasing v0.0.1 of the action so people could start using it already. For context, I intentionally did not invest effort into refactoring now to avoid postponing the action release.

WDYT?

Yantrio · 2023-10-12T09:32:43Z

@kislerdm Thanks for the quick reply and your efforts here!

I trust your judgement on my comments here to change what you think needs changing. Most of these are small nitpicks and can be easily fixed or changed.

for anything substantial requiring some refactoring and re-working, let's do it after in another PR. We can work together to make issues on things you want to do post-PR once you've had another go over my comments.

Thanks again! 🙌

Signed-off-by: Dmitry Kisler <[email protected]>

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

see: -opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm · 2023-10-12T15:55:12Z

@Yantrio Hey James! Could you please have a look at the changes I made following your suggestions. Thanks!

Yantrio · 2023-10-13T12:39:39Z

I'm happy to approve and we can do more work in other issues/PRs later, I would just like these 2 comments addressing please :)

https://github.com/opentofu/setup-opentofu/pull/2/files#r1356483075
https://github.com/opentofu/setup-opentofu/pull/2/files#r1356477421

Thanks!

see: https://github.com/opentofu/setup-opentofu/pull/2/files#r1356483075 Signed-off-by: Dmitry Kisler <[email protected]>

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm · 2023-10-16T14:39:19Z

@Yantrio Hey James, these comments have been addressed. Please let me know if there are more blockers which shall be tackled before the PR can be merged. Thanks!

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm added 7 commits October 4, 2023 23:09

chore: init docs

699588b

Signed-off-by: Dmitry Kisler <[email protected]>

feat: add action definition

c37e0c5

Signed-off-by: Dmitry Kisler <[email protected]>

feat: ported action definition from setup-terraform

01bef20

Signed-off-by: Dmitry Kisler <[email protected]>

chore: remove action trigger

df6d60e

Signed-off-by: Dmitry Kisler <[email protected]>

chore: rm unused dependency

dbdd2dd

Signed-off-by: Dmitry Kisler <[email protected]>

chore: update node version since it's the one used in the action defi…

9d9b013

…nition. Signed-off-by: Dmitry Kisler <[email protected]>

chore: remote misleading note.

6499537

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm mentioned this pull request Oct 4, 2023

fork setup-terraform into this repo #1

Closed

chore: rename the action definition

23ad720

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm mentioned this pull request Oct 5, 2023

Request: Support for GitHub Action opentofu/opentofu#556

Closed

RoseSecurity reviewed Oct 5, 2023

View reviewed changes

CODE_OF_CONDUCT.md Show resolved Hide resolved

eranelbaz reviewed Oct 5, 2023

View reviewed changes

rdhar suggested changes Oct 5, 2023

View reviewed changes

kislerdm added 7 commits October 9, 2023 22:39

chore: updated the hardcoded value so it's the latest release.

c069485

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: pinned the dependencies

a8c9f4d

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: migrated terraformrc to tofurc

1add52f

details: - opentofu#2 (comment) - opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: migrated null_resource

8b0d49a

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

fix: missing a single quotation mark.

e404d78

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: paraphrasing for clarity

959cb48

Signed-off-by: Dmitry Kisler <[email protected]>

chore: remove redundant config

22b63a0

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm force-pushed the main branch from e93ef0d to 22b63a0 Compare October 9, 2023 22:02

kislerdm added 7 commits October 10, 2023 00:13

fix: ci trial with matrix extension to set wrapper

0c987c5

Signed-off-by: Dmitry Kisler <[email protected]>

fix: ci trial with matrix extension to set wrapper

0806002

Signed-off-by: Dmitry Kisler <[email protected]>

fix: ci trial with matrix extension to set wrapper

fe9ebcf

Signed-off-by: Dmitry Kisler <[email protected]>

chore: cleanup CI definition by adding the dimension to the strategy …

b1f5c54

…matrix - tofu-wrapper flag. chore: adjusted version selection test selection. Signed-off-by: Dmitry Kisler <[email protected]>

chore: removes the constraints step because it must be covered by uni…

137fcca

…t tests. Signed-off-by: Dmitry Kisler <[email protected]>

feat: added versions resolution logic to use user's input.

c68fac3

Signed-off-by: Dmitry Kisler <[email protected]>

feat: added versions resolution logic to use user's input.

45ec8bf

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm force-pushed the main branch from 4c9adaa to 45ec8bf Compare October 10, 2023 09:48

chore: enhances tests.

ae5138e

Signed-off-by: Dmitry Kisler <[email protected]>

virtualroot mentioned this pull request Oct 11, 2023

Add Official GitHub Action virtualroot/awesome-opentofu#3

Closed

cube2222 requested review from Yantrio and cube2222 October 11, 2023 17:57

Yantrio requested changes Oct 12, 2023

View reviewed changes

kislerdm added 6 commits October 12, 2023 17:24

chore: update ver. of reusable workflow

fa9fe16

Signed-off-by: Dmitry Kisler <[email protected]>

chore: replace checkout action's ver.

bbcf56f

see: opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: cleanup gitignore

09232cf

Signed-off-by: Dmitry Kisler <[email protected]>

chore: refactors mapOS func.

ff4f927

Signed-off-by: Dmitry Kisler <[email protected]>

chore: refactors downloadCLI

6196ddd

see: -opentofu#2 (comment) - opentofu#2 (comment) Signed-off-by: Dmitry Kisler <[email protected]>

chore: improves jsdoc.

29bd5d3

Signed-off-by: Dmitry Kisler <[email protected]>

sudosubin mentioned this pull request Oct 13, 2023

feat: Add CI for opentofu actions-python/infra#1

Merged

kislerdm requested a review from Yantrio October 13, 2023 10:18

kislerdm added 9 commits October 16, 2023 16:18

chore: move the disclaimer higher in the readme.

7ea705c

see: https://github.com/opentofu/setup-opentofu/pull/2/files#r1356483075 Signed-off-by: Dmitry Kisler <[email protected]>

chore: update lock

0ee88b7

Signed-off-by: Dmitry Kisler <[email protected]>

chore: update pre-commit

c5f5355

Signed-off-by: Dmitry Kisler <[email protected]>

chore: update pre-commit

faa7895

Signed-off-by: Dmitry Kisler <[email protected]>

chore: update pre-commit

71a21cd

Signed-off-by: Dmitry Kisler <[email protected]>

chore: add lint step

11d153f

Signed-off-by: Dmitry Kisler <[email protected]>

chore: trial

74545a5

Signed-off-by: Dmitry Kisler <[email protected]>

chore: trial

b5e36da

Signed-off-by: Dmitry Kisler <[email protected]>

chore: trial

25378da

Signed-off-by: Dmitry Kisler <[email protected]>

kislerdm added 2 commits October 16, 2023 17:08

fix: fix vulnerability

e5412c2

Signed-off-by: Dmitry Kisler <[email protected]>

chore: add audit step to precommit hooks

35304a0

Signed-off-by: Dmitry Kisler <[email protected]>

Yantrio approved these changes Oct 16, 2023

View reviewed changes

Yantrio merged commit 6b016a1 into opentofu:main Oct 16, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Action v0.0.1 #2

Action v0.0.1 #2

kislerdm commented Oct 4, 2023 •

edited

Loading

eranelbaz left a comment

Yantrio left a comment •

edited

Loading

kislerdm commented Oct 12, 2023 •

edited

Loading

Yantrio commented Oct 12, 2023

kislerdm commented Oct 12, 2023

Yantrio commented Oct 13, 2023

kislerdm commented Oct 16, 2023

Action v0.0.1 #2

Action v0.0.1 #2

Conversation

kislerdm commented Oct 4, 2023 • edited Loading

What changed

Why do we need it

eranelbaz left a comment

Choose a reason for hiding this comment

Yantrio left a comment • edited Loading

Choose a reason for hiding this comment

kislerdm commented Oct 12, 2023 • edited Loading

Yantrio commented Oct 12, 2023

kislerdm commented Oct 12, 2023

Yantrio commented Oct 13, 2023

kislerdm commented Oct 16, 2023

kislerdm commented Oct 4, 2023 •

edited

Loading

Yantrio left a comment •

edited

Loading

kislerdm commented Oct 12, 2023 •

edited

Loading