Invalid oveloading of GL.DrawElements().

[dngs365]

Description

There is an invalid overloading at GL.DrawElements().

Repro steps

Just change your
OpenTK.Graphics.ES20.GL.DrawElements(BeginMode mode, int count, DrawElementsType type, IntPtr indices)
to
OpenTK.Graphics.ES20.GL.DrawElements(BeginMode mode, int count, DrawElementsType type, int offset)
.
May wonder, why use int offset version. That is useful if binding an IBO instead passing an int[].

Expected behavior

The parameter offset means IBO's index element offset.

Actual behavior

Got an UnhandledException.

Related information

In Xamarin.Android using OpenTK-1.0.

LogCat: java.lang.IllegalArgumentException: Requested window android.os.BinderProxy@c2030b6 does not exist.
Maybe the binding information is invalid.

[Nihlus]

Xamarin.Android is a very, very old version of OpenTK which is not actively maintained here. Could you try reproducing the same issue with a newer version of OpenTK?

[UnknownShadow200]

https://github.com/mono/opentk/blob/master/Source/OpenTK/Graphics/ES20.Android/Helper.cs#L369

public static void DrawElements(BeginMode mode, int count, DrawElementsType type, int offset)
{
       DrawElements(mode, count, type, offset);
}

Seems like this would cause a stack overflow?

The overload in this repository (i.e. newer versions of OpenTK) does new IntPtr(offset));

[dngs365]

@Nihlus @UnknownShadow200 I tried to migrate the OpenTK to v2.0, however, the OpenTK.Platform.Android namespace is missing. The Xamarin.Android basically using AndroidGameView which in that namespace. My target is Xamarin.Android v7.1.
I think, the Xamarin just choose stable and common version of OpenTK for integration even though very very old.
If the newer code is like that, I agree, it seems there is no problem.

[UnknownShadow200]

Are you using the android specific project when compiling (or package from nuget)?

[dngs365]

@UnknownShadow200 My project from Visual Studio 2017 with Visual C# > Android > OpenGL Game template. It has OpenTK-1.0 by default without NuGet nor any other dependecy management. The Xamarin has OpenTK-1.0.dll in its own package that distributed by Microsoft.

[UnknownShadow200]

https://www.nuget.org/packages/OpenTK/

I don't have Xamarin.Android myself (nor do I use nuget) so I'm not sure if there's an android package for OpenTK. If there isn't perhaps try compiling the OpenTK.Android project in this repository.

also going to open an issue on mono's OpenTK for this

[varon]

@UnknownShadow200 - We've not yet released android/iOS packages for OpenTK 2.0+.

The major hurdle is getting the Android/iOS stuff building on CI, which is pretty annoying with Xamarin.

From what I've gathered, the source should be fairly stable for now - if you guys can drop some confirmed reports of it working, and perhaps a brief how-to guide, we can look at getting a package released.

[dngs365]

@UnknownShadow200 I missed about migration what I had tried. First, removed 1.0 which added from the Xamarin, and then added 2.0 by NuGet. Finally, OpenTK.Platform.Android was missing.

@varon Unfortunately, I got some doubt about stability of OpenTK because of this issue. I hope to be able to use newest version in Xamarin. Thanks for efforts.

[dngs365]

I found some more about overloading issues that some overloadings are not working properly in Xamarin.
However, using version is not in developing, therefore I'll not list them here.

[UnknownShadow200]

Downloading project from github and compiling OpenTK.Android project didn't work either?

…

On Jun 12, 2017 12:24 AM, "Jong-il Hong" ***@***.***> wrote: I found some more about overloading issues that some overloadings are not working properly in Xamarin. However, using version is not in developing, therefore I'll not list them here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#535 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGNTJFw1BWbYClXp5H9Z51wT_8XVBdLCks5sC_iSgaJpZM4N0Pvj> .