Skip to content

fix(xtest): Adds back java-sdk mlkem feature - #550

Merged
dmihalcik-virtru merged 2 commits into
mainfrom
revert-540-disable-pure-mlkem-java-sdk
Jul 30, 2026
Merged

fix(xtest): Adds back java-sdk mlkem feature#550
dmihalcik-virtru merged 2 commits into
mainfrom
revert-540-disable-pure-mlkem-java-sdk

Conversation

@dmihalcik-virtru

@dmihalcik-virtru dmihalcik-virtru commented Jul 7, 2026

Copy link
Copy Markdown
Member

Reverts #540

Summary by CodeRabbit

  • Bug Fixes
    • Updated feature detection to recognize support for a new ML-KEM encryption mechanism.
    • Improved the support check to verify encryption help output more reliably and accurately reflect the support status via the command result.

@dmihalcik-virtru
dmihalcik-virtru requested review from a team as code owners July 7, 2026 15:30
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f9ea59b8-42f6-4919-a6b8-4390def37497

📥 Commits

Reviewing files that changed from the base of the PR and between 16cd0eb and efa8eb8.

📒 Files selected for processing (1)
  • xtest/sdk/java/cli.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • xtest/sdk/java/cli.sh

📝 Walkthrough

Walkthrough

The Java SDK CLI test script now detects mechanism-mlkem support by checking cmdline.jar help encrypt output for mlkem:768 and returning the pipeline status.

Changes

ML-KEM Support Detection

Layer / File(s) Summary
Add mechanism-mlkem support check
xtest/sdk/java/cli.sh
Adds a supports branch that enables pipeline failure propagation, checks for mlkem:768 case-insensitively, and returns the grep status.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: sujankota

Poem

A rabbit hops through help output,
Finds ML-KEM without a doubt.
One grep checks the magic sign,
Pipeline status draws the line.
“Supported!” cheers this bunny fine. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change to restore the java-sdk mlkem feature in xtest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-540-disable-pure-mlkem-java-sdk

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the 'mechanism-mlkem' mechanism in the Java CLI test script (xtest/sdk/java/cli.sh) by executing the command-line tool and checking for 'mlkem:768' in the help output. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@sonarqubecloud

Copy link
Copy Markdown

@dmihalcik-virtru
dmihalcik-virtru merged commit 268b2f8 into main Jul 30, 2026
27 checks passed
@dmihalcik-virtru
dmihalcik-virtru deleted the revert-540-disable-pure-mlkem-java-sdk branch July 30, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants