-
Notifications
You must be signed in to change notification settings - Fork 3
feat(xtest): support platform-embedded otdfctl for migration to monorepo #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
aafff16
feat(xtest): support platform-embedded otdfctl for migration to monorepo
dmihalcik-virtru a0fee17
fixup ruff format
dmihalcik-virtru 7ca919a
fix(xtest): update remaining otdfctl references for platform monorepo…
dmihalcik-virtru d30514d
fixup pkg.go removes tag prefixes IIRC
dmihalcik-virtru b0e0df2
refactor(xtest): consolidate .version and .module-path into single .v…
dmihalcik-virtru 9e1e43e
feat(sdk-mgr): wire --source option through install artifact command
dmihalcik-virtru e435931
fix(setup-cli-tool): avoid script injection by using env vars for inp…
dmihalcik-virtru 199e71f
Apply suggestion from @gemini-code-assist[bot]
dmihalcik-virtru 38a3fb3
feat(setup-cli-tool): support multiple platform-source Go versions
dmihalcik-virtru 38a3e82
fix: address PR review findings for platform otdfctl migration
dmihalcik-virtru be80bfb
fix(sdk-mgr): accept "standalone" as valid Go source in go_module_path
dmihalcik-virtru 165e2d1
docs(xtest): clarify auto mode resolves releases from standalone
dmihalcik-virtru 4790e3c
fix(setup-cli-tool): require SHA match in auto-detect platform fallback
dmihalcik-virtru 51edb87
fix: harden validation and error handling for platform otdfctl migration
dmihalcik-virtru cf4c44c
fixup ruff format
dmihalcik-virtru 7c4db05
fix: address PR review findings for platform otdfctl migration
dmihalcik-virtru 91953e8
fixup pytest fail
dmihalcik-virtru ca7b39f
Merge branch 'main' into DSPX-2655-migrate-otdfctl
alkalescent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So in default
automode,detect-otdfctlreports platform if the otdfctl dir exists. However,resolve-versionsstill pulls the Go head from the standalone repo (which skips the replace step and the build ends with the published platform modules). Should this condition be on the per-version source fromresolve-versionsinstead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, it will check out a new copy of the platform repo at that tag so the go.work should be correct. I could be wrong; there are a lot of moving parts