-
Notifications
You must be signed in to change notification settings - Fork 3
chore(ci): Improve X-Test workflow performance #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2f94428
docs: Add AGENTS.md and CLAUDE.md
pflynn-virtru 76f65f8
chore(ci): Improve X-Test workflow performance
pflynn-virtru bc3a027
fix(xtest): Guard branch replacement in post-checkout-java.sh
pflynn-virtru b9faaca
fix(xtest): Use version-specific platform.branch in post-checkout-jav…
pflynn-virtru 8ead1a3
fix(xtest): Replace incorrect platform.branch values in Java SDK pom.xml
pflynn-virtru 6bb560f
fix(xtest): Directly replace branch=main when no properties section e…
pflynn-virtru 62641c4
chore(xtest): Update LTS versions to summer 2025 releases
pflynn-virtru 995538e
fix(xtest): Preserve existing protocol/go branch values in Java pom.xml
pflynn-virtru ccfcad9
chore(ci): Update buf-setup-action to match platform config
pflynn-virtru 09602dd
chore(ci): upgrade to buf-action v1.3.0 with BUF_TOKEN for BSR auth
pflynn-virtru 46f21af
chore(ci): add GCP authentication and secret retrieval to xtest workflow
pflynn-virtru acb0762
chore(ci): use vars for GCP auth and secrets in xtest workflow
pflynn-virtru 2921610
chore(ci): upgrade GCP auth action to v3 and update secrets handling
pflynn-virtru 7b1285a
chore(ci): remove unused GCP auth steps from xtest workflow
pflynn-virtru ce1757b
chore(ci): simplify DEFAULT_TAGS in xtest workflow
pflynn-virtru 00823f3
Merge branch 'main' into chore/ci-improve-xtest-workflow-377
pflynn-virtru f77697d
chore(ci): pin actions/cache to specific commit for reproducibility i…
pflynn-virtru 01f8b74
Merge remote-tracking branch 'origin/main' into chore/ci-improve-xtes…
pflynn-virtru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Repository Guidelines | ||
|
|
||
| ## Project Structure & Module Organization | ||
|
|
||
| - `xtest/`: Cross-client compatibility test harness (Python + `pytest`), with fixtures in `xtest/fixtures/` and golden data in `xtest/golden/`. | ||
| - `xtest/sdk/`: Helper scripts and Makefiles for checking out/building SDKs under test (e.g., `xtest/sdk/scripts/checkout-all.sh`, `cd xtest/sdk && make`). | ||
| - `vulnerability/`: Playwright-based security regression tests (`vulnerability/tests/`). | ||
| - `.github/workflows/`: CI workflows (lint/type-check, xtest matrix runs, vulnerability runs). | ||
|
|
||
| ## Build, Test, and Development Commands | ||
|
|
||
| - Enter the dev environment: `devbox shell` (installs Python/JDK/Node per `devbox.json`). | ||
| - Install xtest deps: `cd xtest && uv sync` (or `uv sync --extra dev` for dev tools) | ||
| - Run xtest: `cd xtest && uv run pytest` | ||
| - Focus a subset: `uv run pytest --sdks "go js" --focus go` (see `xtest/conftest.py` options) | ||
| - HTML report: `uv run pytest --html tmp/test-report.html --self-contained-html` | ||
| - Build SDK CLIs (after checkout): `cd xtest/sdk && make` | ||
| - Run vulnerability tests: `cd vulnerability && npm ci && npm test` (requires a running platform; see `README.md` and `vulnerability/README.md`). | ||
|
|
||
| ## Coding Style & Naming Conventions | ||
|
|
||
| - Python code in `xtest/` uses 4-space indentation, `snake_case`, and `pytest`-style fixtures. | ||
| - CI enforces these checks in `xtest/`: | ||
| - `ruff check` and `ruff format --check` | ||
| - `pyright` | ||
| - Local equivalent: `cd xtest && uv sync --extra dev && uv run ruff check . && uv run ruff format --check . && uv run pyright` | ||
|
|
||
| ## Testing Guidelines | ||
|
|
||
| - `pytest` tests live in `xtest/test_*.py`; add new fixtures under `xtest/fixtures/`. | ||
| - Tests assume a platform backend is reachable (Docker + Keycloak). Use `xtest/test.env` as a template: | ||
| - `cd xtest && set -a && source test.env && set +a` | ||
|
|
||
| ## Commit & Pull Request Guidelines | ||
|
|
||
| - Use semantic commit/PR titles (enforced by CI): `feat(xtest): ...`, `fix(vulnerability): ...`, `docs: ...` (types: `fix|feat|chore|docs`; scopes include `xtest`, `vulnerability`, `go`, `java`, `web`, `ci`). | ||
| - DCO sign-off is required: `git commit -s -m "feat(xtest): ..."` (see `CONTRIBUTING.md`). | ||
| - PRs should include a clear description, linked issue (if any), and relevant logs/screenshots for test failures; reviewers are defined in `CODEOWNERS`. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| AGENTS.md | ||
|
pflynn-virtru marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.