fix(attribute groupBy): single groupBy field #91
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmihalcik-virtru
requested review from
dmihalcik-virtru,
jrschumacher and
strantalis
dmihalcik-virtru
approved these changes
Jan 25, 2024
Member
|
@pflynn-virtru we're making a lot of changes in #51 so we should probably hold off until we do the live code-review. @strantalis is going to schedule this meeting. Also feel free to ask questions in that PR and we'll be happy to engage. |
Member
|
Closing and readdressing as new work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AttributeDefinition.GroupBy should be single, not array
see https://github.com/virtru/access-pdp/blob/5f932c3f1184ff34ee30217214b8b7a59be45db2/proto/attributes/v1/attributes.proto#L42