Skip to content

fix: attribute missing rpc method for listing attribute values #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakedoublev merged 1 commit into from
Jan 23, 2024
Merged

fix: attribute missing rpc method for listing attribute values #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion proto/attributes/attributes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,9 @@ message GetValueResponse {
Value value = 1;
}

message ListValuesRequest {}
message ListValuesRequest {
string attribute_id = 1 [(buf.validate.field).required = true];
}
message ListValuesResponse {
repeated Value values = 1;
}
Expand Down Expand Up @@ -191,6 +193,13 @@ service AttributesService {
*/
rpc ListAttributes(ListAttributesRequest) returns (ListAttributesResponse) {}

/*
List Values
Example:
grpcurl -plaintext -d '{"attribute_id": "attribute_id"}' localhost:8080 attributes.AttributesService/ListValues
*/
rpc ListAttributeValues(ListValuesRequest) returns (ListValuesResponse) {}

rpc GetAttribute(GetAttributeRequest) returns (GetAttributeResponse) {
option (google.api.http) = {get: "/attributes/{id}"};
}
Expand Down
Loading