feat(PLAT-3112): Add Elliptic Curve functionality to support nanotdf [PLAT-3112] #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmantru
changed the title
dmihalcik-virtru
previously approved these changes
Apr 12, 2024
sujankota
reviewed
Apr 13, 2024
Member
|
@patmantru I've pushed up a few golang cleanups |
patmantru
force-pushed
the
PLAT-3112-ocrypto-EC-support
branch
from
dc1a6e4 to
ed2ce62
Compare
Contributor
Author
|
No apparent way to both add code and consume it in the same PR, so cutting this back to just adding the new EC code, will add consumption of this code in sdk/nanotdf* in a separate PR once this is merged to main. |
Contributor
Author
|
@strantalis please review |
pflynn-virtru
previously approved these changes
Apr 15, 2024
dmihalcik-virtru
previously approved these changes
Apr 15, 2024
Co-authored-by: Dave Mihalcik <[email protected]>
patmantru
dismissed stale reviews from dmihalcik-virtru and pflynn-virtru
via
22a9f56
strantalis
reviewed
Apr 15, 2024
Member
|
@patmantru I left a couple comments. |
Co-authored-by: Sean Trantalis <[email protected]>
Co-authored-by: Sean Trantalis <[email protected]>
dmihalcik-virtru
previously approved these changes
Apr 15, 2024
added 2 commits
April 15, 2024 16:53
strantalis
approved these changes
Apr 16, 2024
patmantru
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](lib/ocrypto-v0.1.0...lib/ocrypto/v0.1.0) (2024-04-22) ### Features * **kas:** support HSM and standard crypto ([#497](#497)) ([f0cbe03](f0cbe03)) * **PLAT-3112:** Add Elliptic Curve functionality to support nanotdf ([#576](#576)) ([504482a](504482a)) * **PLAT-3112:** Initial consumption of ec_key_pair functions by nanotdf ([#586](#586)) ([5e2cba0](5e2cba0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
tech-guru42
added a commit
to tech-guru42/TDF
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@lib/ocrypto-v0.1.0...lib/ocrypto/v0.1.0) (2024-04-22) ### Features * **kas:** support HSM and standard crypto ([#497](opentdf/platform#497)) ([f0cbe03](opentdf/platform@f0cbe03)) * **PLAT-3112:** Add Elliptic Curve functionality to support nanotdf ([#576](opentdf/platform#576)) ([504482a](opentdf/platform@504482a)) * **PLAT-3112:** Initial consumption of ec_key_pair functions by nanotdf ([#586](opentdf/platform#586)) ([5e2cba0](opentdf/platform@5e2cba0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
passion-127
added a commit
to passion-127/TDF
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](opentdf/platform@lib/ocrypto-v0.1.0...lib/ocrypto/v0.1.0) (2024-04-22) ### Features * **kas:** support HSM and standard crypto ([#497](opentdf/platform#497)) ([f0cbe03](opentdf/platform@f0cbe03)) * **PLAT-3112:** Add Elliptic Curve functionality to support nanotdf ([#576](opentdf/platform#576)) ([504482a](opentdf/platform@504482a)) * **PLAT-3112:** Initial consumption of ec_key_pair functions by nanotdf ([#586](opentdf/platform#586)) ([5e2cba0](opentdf/platform@5e2cba0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLAT-3112
Nanotdf needs some EC functions, add them to the ocrypto library