Skip to content

Conversation

@elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Apr 4, 2024

needed to properly load individual service configs

@elizabethhealy elizabethhealy marked this pull request as ready for review April 4, 2024 21:43
@elizabethhealy elizabethhealy requested a review from a team as a code owner April 4, 2024 21:43
@strantalis
Copy link
Member

@elizabethhealy Are you getting an error?

It should still map to services

@elizabethhealy
Copy link
Member Author

elizabethhealy commented Apr 4, 2024

@strantalis i wasnt getting an error but it wasnt properly loading the configs for the individual services until i changed the key, the service.config.extraprops was empty

@elizabethhealy elizabethhealy changed the title fix(config): Fix config yamls after folder rename services -> service fix(config): Fix yaml path for individual service config loading Apr 4, 2024
@elizabethhealy
Copy link
Member Author

@strantalis found the actual cause of the error -- the key in the viper command loading the individual configs -- not sure why this worked before

@jrschumacher
Copy link
Member

We switched from services to service pretty fast. Maybe it was an outlier?

@strantalis
Copy link
Member

strantalis commented Apr 4, 2024

@elizabethhealy Can you try the branch on this pr #524

@strantalis
Copy link
Member

@elizabethhealy
Copy link
Member Author

closing in favor of #524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants