Temporarily remove hsm #462
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strantalis
reviewed
Mar 26, 2024
| } | ||
|
|
||
| func (session *HSMSession) DecryptOAEP(key *PrivateKeyRSA, ciphertext []byte, hashFunction crypto.Hash, label []byte) ([]byte, error) { | ||
| func (session *HSMSession) DecryptOAEP(key RSAPrivateKey, ciphertext []byte, hashFunction crypto.Hash, label []byte) ([]byte, error) { |
Member
There was a problem hiding this comment.
I think we can remove passing in the private key and just leave the function signature as
func (session *HSMSession) DecryptOAEP(hash crypto.Hash, cipherText []byte, label []byte)
The reason I mention this is because on startup when we create an hsm session or standard crypto we are already loading the private key into the struct so internally we have all the information needed for decrypt.
Just some thoughts.
Member
|
resolved by #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.