fix(security): adds a new encryption keypair #430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleene
approved these changes
Mar 19, 2024
Contributor
mkleene
left a comment
mkleene
left a comment
There was a problem hiding this comment.
looks good once you take care of any build stuff, found this in the logs:
Error: auth/token_adding_interceptor_test.go:119:34: cannot use &ts (value of type *FakeTokenSource) as AccessTokenSource value in argument to NewTokenAddingInterceptor: *FakeTokenSource does not implement AccessTokenSource (missing method EncryptionPublicKeyPEM)
| // more closely linked to what happens in KAS in terms of crypto params | ||
| DecryptWithDPoPKey(data []byte) ([]byte, error) | ||
| MakeToken(func(jwk.Key) ([]byte, error)) ([]byte, error) | ||
| DPoPPublicKeyPEM() string |
Contributor
There was a problem hiding this comment.
We can get rid of DPoPPublicKeyPEM, I think
strantalis
requested changes
Mar 20, 2024
Member
strantalis
left a comment
strantalis
left a comment
There was a problem hiding this comment.
I am not sure the asym keys used for kas rewrap encryption should be on the IDP Access token. Those should get created and stored when we load a tdf. They have nothing to do with the oauth flow imo.
dmihalcik-virtru
changed the title
Member
|
#461 resolves this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.