Skip to content

fix(sdk): use the dialoptions even with no client credentials #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkleene merged 2 commits into from
Mar 14, 2024
Merged

fix(sdk): use the dialoptions even with no client credentials #400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47977b6
fix(sdk): use the dialoptions even with no client credentials
mkleene Mar 14, 2024
bdf12f3
Update sdk.go
mkleene Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func buildKASClient(c *config) (KASClient, error) {
// at this point we have either both client credentials and a token endpoint or none of the above. if we don't have
// any just return a KAS client that can only get public keys
if c.clientCredentials.ClientId == "" {
return KASClient{}, nil
return KASClient{dialOptions: c.build()}, nil
}

ts, err := NewIDPAccessTokenSource(
Expand Down