fix(ers): address inline claims review feedback

[jrschumacher]

Summary

• normalize typed JWT claim slices ([]float64, []bool, and []int) before structpb serialization
• add regression coverage proving typed and nested claim slices are accepted by structpb.NewStruct
• remove inappropriate t.Helper() calls from top-level tests
• use testify/require consistently in the tests introduced by fix(ers): pass inline claims through multi-strategy context #3794

Testing

• cd service && go test ./pkg/protohelper ./entityresolution/multi-strategy ./entityresolution/multi-strategy/v2 -count=1
• cd service && golangci-lint run ./pkg/protohelper ./entityresolution/multi-strategy ./entityresolution/multi-strategy/v2
• cd tests-bdd && go test ./cukes -run "^TestConvertInterfaceToAny_PlainClaimsJSON$" -count=1
• cd tests-bdd && golangci-lint run --disable nestif ./cukes (the package has a pre-existing nestif finding in steps_localplatform.go)

Context

Follow-up to review comments on #3794, stacked above #3809 so the existing ERS PR stack can merge without another restack.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 85ac0d28-737b-463c-b801-b1eeb8a9a5f5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	102.402291ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	53.026558ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	240.61461ms
Throughput	415.60 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	28.117137646s
Average Latency	280.159186ms
Throughput	177.83 requests/second

[elizabethhealy]

ty!

[github-actions]

X-Test Results

✅ go@pull-3836-pull-3836
✅ go@pull-3836-main
✅ go@main-main
✅ go@main-pull-3836
✅ go@main-v0.9.0
✅ go@pull-3836-v0.9.0
✅ java@main-pull-3836
✅ java@main-main
✅ js@main-pull-3836
✅ js@main-main
✅ java@main-v0.9.0
✅ js@main-v0.9.0
cukes-report
govulncheck-failure-8
govulncheck-failure-1
govulncheck-failure-5
opentdfplatformJOQ16M.dockerbuild
govulncheck-failure-3
govulncheck-failure-0
govulncheck-failure-2

Invalidated by push of 079f8f1

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	203.401723ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	112.640025ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	426.484801ms
Throughput	234.47 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	49.347897826s
Average Latency	490.080927ms
Throughput	101.32 requests/second

[github-actions]

X-Test Results

✅ go@main-main
✅ go@pull-3836-pull-3836
✅ go@pull-3836-main
✅ go@main-v0.9.0
✅ go@main-pull-3836
✅ java@main-pull-3836
✅ java@main-main
✅ js@main-main
cukes-report
✅ go@pull-3836-v0.9.0
✅ js@main-pull-3836
✅ java@main-v0.9.0
✅ js@main-v0.9.0
opentdfplatformHZGQYK.dockerbuild
govulncheck-failure-8
govulncheck-failure-1
govulncheck-failure-2
govulncheck-failure-3
govulncheck-failure-5

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	160.760916ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	91.042066ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	541.370553ms
Throughput	184.72 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	49.927169136s
Average Latency	497.815538ms
Throughput	100.15 requests/second

[github-actions]

X-Test Results

✅ go@main-main
✅ go@pull-3836-main
✅ go@pull-3836-v0.9.0
✅ go@pull-3836-pull-3836
✅ go@main-pull-3836
✅ go@main-v0.9.0
✅ java@main-main
bats-test-results
✅ js@main-main
✅ java@main-pull-3836
✅ java@main-v0.9.0
✅ js@main-v0.9.0
cukes-report
✅ js@main-pull-3836
govulncheck-failure-0
govulncheck-failure-8
opentdfplatform2I0G2K.dockerbuild
govulncheck-failure-5
govulncheck-failure-1
govulncheck-failure-3
govulncheck-failure-2

[github-actions]

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

• examples
• otdfctl
• sdk
• service
• lib/fixtures
• tests-bdd

See the workflow run for details.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	195.931714ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	108.93019ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	436.933432ms
Throughput	228.87 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	51.994810333s
Average Latency	517.053922ms
Throughput	96.16 requests/second

[github-actions]

X-Test Results

✅ go@main-main
✅ go@pull-3836-main
✅ go@pull-3836-pull-3836
✅ go@main-v0.9.0
✅ go@main-pull-3836
cukes-report
✅ java@main-pull-3836
✅ js@main-main
✅ js@main-pull-3836
✅ java@main-main
✅ java@main-v0.9.0
✅ go@pull-3836-v0.9.0
✅ js@main-v0.9.0
opentdfplatformHF96MB.dockerbuild
govulncheck-failure-8
govulncheck-failure-3
govulncheck-failure-0
govulncheck-failure-2
govulncheck-failure-1
govulncheck-failure-5