Skip to content

fix(core): prevent OpenTelemetry resource schema conflicts - #3769

Merged
jakedoublev merged 2 commits into
mainfrom
fix/otel-resource-schema-conflict
Jul 22, 2026
Merged

fix(core): prevent OpenTelemetry resource schema conflicts#3769
jakedoublev merged 2 commits into
mainfrom
fix/otel-resource-schema-conflict

Conversation

@jakedoublev

@jakedoublev jakedoublev commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • align OpenTelemetry dependencies on v1.44
  • prevent tracer resource schema conflicts

Summary by CodeRabbit

  • Maintenance
    • Updated observability components and semantic conventions to newer versions.
    • Refreshed supporting networking, gateway, and protocol dependencies.
    • No user-facing functionality or configuration changes.

Signed-off-by: jakedoublev <jake.vanvorhis@virtru.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b9bcf01b-28a9-48ec-9553-823e754ac981

📥 Commits

Reviewing files that changed from the base of the PR and between 5bae1eb and 0064053.

⛔ Files ignored due to path filters (1)
  • service/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • service/go.mod
  • service/tracing/otel.go

📝 Walkthrough

Walkthrough

OpenTelemetry modules, related indirect dependencies, and the tracing semantic conventions import were updated to newer versions. No exported APIs or tracing behavior were changed.

Changes

Telemetry dependency refresh

Layer / File(s) Summary
Dependency and semantic convention updates
service/go.mod, service/tracing/otel.go
OpenTelemetry modules, related indirect dependencies, and the semantic conventions import were advanced to newer versions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: c-r33d

Poem

A rabbit hops through versions bright,
OTEL modules take their flight.
Semantic keys align anew,
While Go dependencies update too.
No APIs change—just carrots in the queue!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title aligns with the PR objective of preventing OpenTelemetry resource schema conflicts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/otel-resource-schema-conflict

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
service/go.mod

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: jakedoublev <jake.vanvorhis@virtru.com>
@jakedoublev
jakedoublev marked this pull request as ready for review July 22, 2026 16:14
@jakedoublev
jakedoublev requested review from a team as code owners July 22, 2026 16:14
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 219.332939ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 119.727029ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 427.629594ms
Throughput 233.85 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 53.836800992s
Average Latency 536.297604ms
Throughput 92.87 requests/second

@jakedoublev
jakedoublev enabled auto-merge July 22, 2026 16:15
@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 199.425582ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 112.96269ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 439.10565ms
Throughput 227.74 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 51.203065446s
Average Latency 510.114677ms
Throughput 97.65 requests/second

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • examples
  • otdfctl
  • sdk
  • service
  • lib/fixtures
  • tests-bdd

See the workflow run for details.

@jakedoublev
jakedoublev added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 4a0c41c Jul 22, 2026
46 checks passed
@jakedoublev
jakedoublev deleted the fix/otel-resource-schema-conflict branch July 22, 2026 16:47
khvirtru pushed a commit to khvirtru/platform that referenced this pull request Jul 24, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.21.0](opentdf/platform@service/v0.20.0...service/v0.21.0)
(2026-07-22)


### ⚠ BREAKING CHANGES

* **policy:** GetPC does not respect manager field.
([opentdf#3752](opentdf#3752))

### Features

* **core:** Update fixtures
([opentdf#3766](opentdf#3766))
([9ac1640](opentdf@9ac1640))
* **policy:** add entitleable namespace field and narrow-read-API doc
corrections ([opentdf#3727](opentdf#3727))
([0fc2f01](opentdf@0fc2f01))
* **policy:** Add name and manager lookup
([opentdf#3753](opentdf#3753))
([bfbc65d](opentdf@bfbc65d))
* **policy:** Add UnsafeUpdateKey implementation
([opentdf#3731](opentdf#3731))
([cd47518](opentdf@cd47518))
* **policy:** Add UnsafeUpdateKey rpc.
([opentdf#3728](opentdf#3728))
([c89b193](opentdf@c89b193))
* **policy:** create subject mappings with attribute values
([opentdf#3741](opentdf#3741))
([718320b](opentdf@718320b))
* **policy:** deprecate GetAttributeValuesByFqns in favor of narrow read
APIs ([opentdf#3745](opentdf#3745))
([baba709](opentdf@baba709))
* **policy:** dynamic attribute value entitlement mappings
([opentdf#3568](opentdf#3568))
([21e95e0](opentdf@21e95e0))
* **policy:** populate entitleable definition namespace
([opentdf#3737](opentdf#3737))
([3f32839](opentdf@3f32839))


### Bug Fixes

* **authz:** use standard Keycloak token exchange
([opentdf#3754](opentdf#3754))
([de9ae0d](opentdf@de9ae0d))
* **core:** Pass the platform logger to the authz role provider factory
([opentdf#3732](opentdf#3732))
([9c32554](opentdf@9c32554))
* **core:** prevent OpenTelemetry resource schema conflicts
([opentdf#3769](opentdf#3769))
([4a0c41c](opentdf@4a0c41c))
* **deps:** bump github.com/opentdf/platform/protocol/go from 0.38.0 to
0.39.0 in /service
([opentdf#3764](opentdf#3764))
([8d430f5](opentdf@8d430f5))
* **ers:** coerce attempted_strategies []string to []interface{} for
structpb ([opentdf#3645](opentdf#3645))
([71d6e90](opentdf@71d6e90))
* **policy:** GetPC does not respect manager field.
([opentdf#3752](opentdf#3752))
([0d3c0a0](opentdf@0d3c0a0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants