Skip to content

fix(ci): DSPX-3086 Updates checks.yaml xtest to prefer in-repo otdfctl - #3420

Closed
dmihalcik-virtru wants to merge 1 commit into
mainfrom
dmihalcik-virtru-patch-1
Closed

fix(ci): DSPX-3086 Updates checks.yaml xtest to prefer in-repo otdfctl#3420
dmihalcik-virtru wants to merge 1 commit into
mainfrom
dmihalcik-virtru-patch-1

Conversation

@dmihalcik-virtru

@dmihalcik-virtru dmihalcik-virtru commented Apr 30, 2026

Copy link
Copy Markdown
Member

Proposed Changes

  • Add 'otdfctl-source' input to xtest workflow.
  • This will update future calls to use otdfctl within this repo by default

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

Summary by CodeRabbit

  • Chores
    • Updated internal testing workflow configuration.

Add 'otdfctl-source' input to xtest workflow.
@dmihalcik-virtru
dmihalcik-virtru requested review from a team as code owners April 30, 2026 15:04
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d025a708-81fd-434a-8713-b64afe451162

📥 Commits

Reviewing files that changed from the base of the PR and between 3d2130d and c87dd83.

📒 Files selected for processing (1)
  • .github/workflows/checks.yaml

📝 Walkthrough

Walkthrough

A workflow configuration parameter is added to the checks.yaml file, setting otdfctl-source to platform when invoking the reusable opentdf/tests workflow for the platform extended tests job.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/checks.yaml
Added otdfctl-source: platform input parameter to the platform-xtest job's reusable workflow invocation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

comp:ci, size/xs

Suggested reviewers

  • elizabethhealy
  • jakedoublev

Poem

🐰 A workflow takes shape, so small and so neat,
One parameter added, the config's complete!
Platform now speaks where tests convene,
The smallest of changes, a workflow's routine. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding an 'otdfctl-source' parameter to the xtest workflow in checks.yaml to prefer the in-repo otdfctl binary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dmihalcik-virtru-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/xs comp:ci Github Actions Work labels Apr 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 174.60901ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 88.678995ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 433.469958ms
Throughput 230.70 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 42.401945733s
Average Latency 421.790503ms
Throughput 117.92 requests/second

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • tests-bdd

See the workflow run for details.

@github-actions

Copy link
Copy Markdown
Contributor

@dmihalcik-virtru

Copy link
Copy Markdown
Member Author

closed in favor of opentdf/tests#445

@dmihalcik-virtru
dmihalcik-virtru deleted the dmihalcik-virtru-patch-1 branch April 30, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:ci Github Actions Work size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant