Skip to content

fix(sdk): require at least one FQN in ForAttributeValues #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marythought merged 1 commit into from
Apr 22, 2026
+15 −11
Merged

fix(sdk): require at least one FQN in ForAttributeValues #3355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions protocol/go/authorization/v2/resource.gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions protocol/go/internal/authorization/v2/resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import (
// ForAttributeValues returns a Resource containing the given attribute value FQNs.
// This is the most common Resource variant, used when authorizing against
// attribute values attached to data (e.g. those on a TDF).
// At least one FQN is required; calling with zero arguments panics.
func ForAttributeValues(fqns ...string) *authorizationv2.Resource {
if len(fqns) == 0 {
panic("ForAttributeValues requires at least one FQN")
}
return &authorizationv2.Resource{
Resource: &authorizationv2.Resource_AttributeValues_{
AttributeValues: &authorizationv2.Resource_AttributeValues{
Expand Down
18 changes: 7 additions & 11 deletions protocol/go/internal/authorization/v2/resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,13 @@ func TestForAttributeValues_Single(t *testing.T) {
}
}

func TestForAttributeValues_ZeroArgs(t *testing.T) {
r := ForAttributeValues()

av, ok := r.GetResource().(*authorizationv2proto.Resource_AttributeValues_)
if !ok {
t.Fatal("expected AttributeValues resource")
}
got := av.AttributeValues.GetFqns()
if len(got) != 0 {
t.Fatalf("fqns len = %d, want 0", len(got))
}
func TestForAttributeValues_ZeroArgs_Panics(t *testing.T) {
defer func() {
if r := recover(); r == nil {
t.Fatal("expected panic for zero FQNs, but did not panic")
}
}()
ForAttributeValues()
}

func TestForRegisteredResourceValueFqn(t *testing.T) {
Expand Down
Loading