Skip to content

fix(core): do not concat slashes directly in url/file paths #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakedoublev merged 3 commits into from
Apr 9, 2026
Merged

fix(core): do not concat slashes directly in url/file paths #3290

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2218b0d
fix(core): do not concat slashes directly in url/file paths
jakedoublev Apr 9, 2026
1e2c697
rm linter directives when we have not yet added the linter
jakedoublev Apr 9, 2026
bb60238
use path.Join to not url-encode resources differently than today
jakedoublev Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/codegen/runner/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func New%s%s%sConnectWrapper(httpClient connect.HTTPClient, baseURL string, opts
prefix,
interfaceName,
packagePath,
packagePath+"/"+connectPackageName,
path.Join(packagePath, connectPackageName),
prefix,
interfaceName,
suffix,
Expand Down
5 changes: 4 additions & 1 deletion service/internal/auth/authn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,10 @@ func (a Authentication) ConnectUnaryServerInterceptor() connect.UnaryInterceptor

// parse the rpc method
p := strings.Split(req.Spec().Procedure, "/")
resource := p[1] + "/" + p[2]
resource, err := url.JoinPath(p[1], p[2])
if err != nil {
return nil, connect.NewError(connect.CodeInternal, fmt.Errorf("invalid procedure path: %w", err))
}
Comment thread
jakedoublev marked this conversation as resolved.
Outdated
Comment thread
jakedoublev marked this conversation as resolved.
Outdated
action := getAction(p[2])

token, ctxWithJWK, err := a.checkToken(
Expand Down
Loading