-
Notifications
You must be signed in to change notification settings - Fork 39
feat(cli): migrate otdfctl into platform monorepo #3205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
eea5344
Add 'otdfctl/' from commit '82849975b6a1f389652bc6b93cf33a08d2d33d67'
alkalescent 91cd0b0
feat(cli): migrate otdfctl into platform monorepo (#3205)
alkalescent be84709
feat(cli): update otdfctl module path and go.work integration (#3207)
alkalescent 72473a7
feat(cli): Makefile and build scripts (#3208)
alkalescent 41b68c2
feat(cli): add otdfctl to platform CI matrix (#3221)
alkalescent cd2fab1
feat(cli): migrate e2e tests and fix lint errors (#3236)
alkalescent 65dde21
feat(cli): Add namespace migration schemas. (#3269)
c-r33d b8db0c6
feat(cli): Add migrate and prune commands. (#3273)
c-r33d b77aeb7
feat(cli): independent otdfctl releases (#3268)
alkalescent ee30b07
feat(cli): Build migration plan (#3297)
c-r33d 5ce0de9
chore(ci): add otdfctl to dependabot configuration (#3291)
alkalescent 32d5663
feat(cli): Add skeleton of executor and action only commits (#3301)
c-r33d 7d6fa22
feat(cli): SCS commit (#3304)
c-r33d 11bbce0
feat(cli): Subject mapping commit (#3305)
c-r33d ea87a9a
fix(ci): prevent code injection in release-otdfctl workflow (#3308)
alkalescent 97dce10
feat(cli): Obligation trigger commit (#3306)
c-r33d 6475ea0
feat(cli): RR commit. (#3309)
c-r33d f2d0f3c
fix: lint issue (#3326)
alkalescent d04286e
feat(cli): Cleanup planner, handle unresolved RRs interactively. (#3311)
c-r33d 5e7ec70
fix: service lint issues (#3329)
alkalescent 5a5778e
feat(cli): Namespaced migration tests. (#3324)
c-r33d c90740d
feat(cli): add more unit testing around the interactive review. (#3336)
c-r33d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json", | ||
| "release-type": "go", | ||
| "versioning": "always-bump-patch", | ||
| "separate-pull-requests": true, | ||
| "include-component-in-tag": true, | ||
| "pull-request-title-pattern": "chore(release): release ${component} ${version}", | ||
| "tag-separator": "/", | ||
| "packages": { | ||
| "otdfctl": { | ||
| "component": "otdfctl", | ||
| "extra-files": [ | ||
| { | ||
| "type": "generic", | ||
| "path": "pkg/config/config.go" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: "Build otdfctl CLI Binaries" | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| build: | ||
| if: ${{ startsWith(github.event.release.tag_name, 'otdfctl/') }} | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0 | ||
| with: | ||
| go-version-file: otdfctl/go.mod | ||
|
|
||
| - name: Extract version from tag | ||
| id: version | ||
| env: | ||
| TAG: ${{ github.event.release.tag_name }} | ||
| run: | | ||
| VERSION="${TAG#otdfctl/v}" | ||
| echo "version=${VERSION}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Build cross-platform binaries | ||
| working-directory: otdfctl | ||
| env: | ||
| SEM_VER: ${{ steps.version.outputs.version }} | ||
| COMMIT_SHA: ${{ github.sha }} | ||
| run: make build | ||
|
|
||
| - name: Upload release artifacts | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| RELEASE_TAG: ${{ github.event.release.tag_name }} | ||
| run: gh release upload "$RELEASE_TAG" ./otdfctl/output/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| ## Summary | ||
|
|
||
| We are planning to migrate the `otdfctl` CLI from this standalone repository into the [`opentdf/platform`](https://github.com/opentdf/platform) monorepo. After migration, this repository will be archived and marked read-only. | ||
|
|
||
| ## Why | ||
|
|
||
| - otdfctl already depends heavily on platform (SDK, protocol, libs) and uses platform's reusable CI workflows | ||
| - Both repos run each other's e2e tests in CI — consolidating eliminates cross-repo coordination overhead | ||
| - The platform monorepo already supports per-component releases (service, sdk, libs), so otdfctl can maintain independent release cadence | ||
|
|
||
| ## What changes for users | ||
|
|
||
| - **Go module path** will change from `github.com/opentdf/otdfctl` to `github.com/opentdf/platform/otdfctl` | ||
| - **Release tags** will change from `v0.X.Y` to `otdfctl/v0.X.Y` | ||
| - **This repository** will be archived (read-only) — all existing releases and tags will remain accessible | ||
| - A notice will be added to this README pointing to the new location | ||
|
|
||
| ## What stays the same | ||
|
|
||
| - The `otdfctl` binary name and CLI interface | ||
| - Separate release cadence (not coupled to platform service releases) | ||
| - All existing CI tests continue to run | ||
|
|
||
| ## Feedback | ||
|
|
||
| If you have concerns or questions about this migration, please comment on this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ use ( | |
| ./lib/flattening | ||
| ./lib/identifier | ||
| ./lib/ocrypto | ||
| ./otdfctl | ||
| ./protocol/go | ||
| ./sdk | ||
| ./service | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / zizmor
insufficient cooldown in Dependabot updates: insufficient implicit default-days (less than 7) Warning