chore(ci): Fix bad watch.sh args on old branches

[dmihalcik-virtru]

Proposed Changes

• Pull a fixed version of watch.sh down, instead of the current branch version

Checklist

• I have added or updated unit tests
• I have added or updated integration tests (if appropriate)
• I have added or updated documentation

Testing Instructions

[gemini-code-assist]

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a CI issue where the watch.sh script might be using incorrect arguments when executed on older branches. The start-up-with-containers GitHub Actions workflow has been updated to ensure that the CI environment consistently uses the correct, fixed versions of init-temp-keys.sh, docker-compose.yaml, and watch.sh by downloading them from a specific watch-sh-fix tag, thereby preventing failures related to outdated scripts.

Highlights

• CI Workflow Update: The start-up-with-containers GitHub Action workflow has been modified to ensure consistent script versions across branches.
• Script Download Fix: The workflow now explicitly downloads init-temp-keys.sh, docker-compose.yaml, and watch.sh from a dedicated watch-sh-fix tag.
• watch.sh Inclusion: The watch.sh script has been added to the list of files fetched from a fixed tag, addressing potential issues with incorrect arguments on older branches.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

CI script now fixed, Old branches run true and fast, Green checks light the way.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue with watch.sh on older branches by downloading a specific version of the script. The change is correct, but the script can be improved for better readability, maintainability, and robustness. I've suggested refactoring the download script to use a variable for the repeated base URL and to add error handling to the curl commands.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	192.927621ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	112.468564ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	404.039614ms
Throughput	247.50 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	40.631474239s
Average Latency	404.46529ms
Throughput	123.06 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	29.78606724s
Average Latency	297.016376ms
Throughput	167.86 requests/second

[github-actions]

X-Test Failure Report

opentdfplatformWE8LX9.dockerbuild
cukes-report
❌ js-pull-2994
❌ java-pull-2994
bats-test-results
test-cases-mapping-report
❌ go-pull-2994