Skip to content

feat(policy): Return built obligations fqns with triggers. #2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 22, 2025
Merged

feat(policy): Return built obligations fqns with triggers. #2830

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c63f1e0
feat(policy): Return built obligations fqns with triggers.
c-r33d Oct 22, 2025
ba919ab
fix gemini comments.
c-r33d Oct 22, 2025
85098e2
fix test.
c-r33d Oct 22, 2025
57c2ad5
simplify code.
c-r33d Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions service/integration/obligation_triggers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ func (s *ObligationTriggersSuite) validateTrigger(actual *policy.ObligationTrigg

// Validate attribute value
s.Require().Equal(expectedAttributeValue.GetId(), actual.GetAttributeValue().GetId())
s.Require().NotEmpty(expectedAttributeValue.GetFqn())
s.Require().Equal(expectedAttributeValue.GetFqn(), actual.GetAttributeValue().GetFqn())
s.Require().Equal(expectedAttributeValue.GetValue(), actual.GetAttributeValue().GetValue())

Expand Down
11 changes: 11 additions & 0 deletions service/policy/db/obligations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,12 @@ func (c PolicyDBClient) CreateObligationTrigger(ctx context.Context, r *obligati
return nil, err
}

returnedOblVal := trigger.GetObligationValue()
if returnedOblVal != nil {
returnedOblVal.Fqn = oblVal.GetFqn()
trigger.ObligationValue = returnedOblVal
}

trigger.Metadata = metadata

return trigger, nil
Expand Down Expand Up @@ -694,6 +700,11 @@ func (c PolicyDBClient) ListObligationTriggers(ctx context.Context, r *obligatio
return nil, nil, err
}

returnedOblVal := obligationTrigger.GetObligationValue()
if returnedOblVal != nil {
returnedOblVal.Fqn = identifier.BuildOblValFQN(returnedOblVal.GetObligation().GetNamespace().GetFqn(), returnedOblVal.GetObligation().GetName(), returnedOblVal.GetValue())
obligationTrigger.ObligationValue = returnedOblVal
}
obligationTrigger.Metadata = metadata
result = append(result, obligationTrigger)
}
Expand Down
Loading