Skip to content

fix(core): Don't require known manager names [backport to release/service/v0.10] #2815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2025
Merged

fix(core): Don't require known manager names [backport to release/service/v0.10] #2815

merged 1 commit into from
Oct 17, 2025

Conversation

@opentdf-automation
Copy link
Contributor

Description

Backport of #2792 to release/service/v0.10.

@opentdf-automation opentdf-automation bot requested review from a team as code owners October 17, 2025 12:17
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 17, 2025
Merged
3 tasks
@opentdf-automation
fix(core): Don't require known manager names (#2792)
c06bb3f 
### Proposed Changes

* The policy service's list of known managers is not exhaustive; that is
up to each KAS
* Adds more logging to help identify misspelled or forgotten mgrs

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

(cherry picked from commit 8a56a96)
@opentdf-automation opentdf-automation bot force-pushed the backport-2792-to-release/service/v0.10 branch from e90916a to c06bb3f Compare October 17, 2025 12:17
@github-actions github-actions bot added size/s comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) comp:kas Key Access Server labels Oct 17, 2025
@github-actions
Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 191.547174ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 88.19044ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 360.852706ms
Throughput 277.12 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 38.798823069s
Average Latency 386.556394ms
Throughput 128.87 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 26.273883768s
Average Latency 261.343774ms
Throughput 190.30 requests/second

@github-actions
Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 193.999165ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 98.526492ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 356.201047ms
Throughput 280.74 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.438519599s
Average Latency 372.408578ms
Throughput 133.55 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.69264768s
Average Latency 255.735892ms
Throughput 194.61 requests/second

@dmihalcik-virtru dmihalcik-virtru merged commit cf87419 into release/service/v0.10 Oct 17, 2025
28 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the backport-2792-to-release/service/v0.10 branch October 17, 2025 13:30
@opentdf-automation opentdf-automation bot mentioned this pull request Oct 17, 2025
Merged
dmihalcik-virtru pushed a commit that referenced this pull request Oct 17, 2025
@opentdf-automation
chore(release): release service 0.10.1 (#2817)
a7e3373 
🤖 I have created a release *beep* *boop*
---


##
[0.10.1](service/v0.10.0...service/v0.10.1)
(2025-10-17)


### Bug Fixes

* **core:** Don't require known manager names [backport to
release/service/v0.10]
([#2815](#2815))
([cf87419](cf87419))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

@c-r33d c-r33d c-r33d approved these changes

Assignees

No one assigned

Labels

comp:kas Key Access Server comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) size/s

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dmihalcik-virtru @c-r33d