Skip to content

fix(ci): Partial rollback of #2793 #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(ci): Partial rollback of #2793 #2796

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4a502
fix(ci): Partial rollback of #2793
dmihalcik-virtru Oct 10, 2025
a0de1a3
gencode
dmihalcik-virtru Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions service/policy/attributes/attributes.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@
policy.Value value = 1;
}

message GetAttributeValuesByFqnsRequest {

Check failure on line 279 in service/policy/attributes/attributes.proto

View workflow job for this annotation

GitHub Actions / Protocol Buffer Lint and Gencode Up-to-date check 

Previously present reserved range "[2]" on message "GetAttributeValuesByFqnsRequest" is missing values: [2] were removed.

Check failure on line 279 in service/policy/attributes/attributes.proto

View workflow job for this annotation

GitHub Actions / Protocol Buffer Lint and Gencode Up-to-date check 

Previously present reserved name "with_value" on message "GetAttributeValuesByFqnsRequest" was deleted.
// Required
// Fully Qualified Names of attribute values (i.e. https://<namespace>/attr/<attribute_name>/value/<value_name>), normalized to lower case.
repeated string fqns = 1 [(buf.validate.field).repeated = {
Expand All @@ -284,9 +284,10 @@
max_items: 250
}];

reserved 2;
reserved "with_value";
// Deprecated
policy.AttributeValueSelector with_value = 2;
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To properly mark this field as deprecated, you should use the deprecated option. This allows protobuf compilers and tools to issue warnings when the field is used. This follows the Google Protocol Buffers style guide for deprecating fields.

Suggested change
policy.AttributeValueSelector with_value = 2;
policy.AttributeValueSelector with_value = 2 [deprecated = true];

}

message GetAttributeValuesByFqnsResponse {
message AttributeAndValue {
policy.Attribute attribute = 1;
Expand Down
Loading