Skip to content

fix(sdk): Fix the bug in ResourceLocator serialization logic #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 17, 2025
+138 −45
Merged

fix(sdk): Fix the bug in ResourceLocator serialization logic #2791

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f9064ed
fix(sdk): Fix the bug in ResourceLocator serialization logic
sujankota Oct 7, 2025
ad66c50
refacoring
sujankota Oct 7, 2025
c422b2e
cleanup
sujankota Oct 7, 2025
07484c0
Update unit tests
sujankota Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions sdk/resource_locator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,21 +282,25 @@ func (rl *ResourceLocator) setURLWithIdentifier(url string, identifier string) e
if len(urlBody) > kMaxBodyLen {
return errors.New("URL too long")
}
padding := ""
identifierLen := len(identifier)
switch {
case identifierLen == 0:
rl.protocol = urlProtocolHTTPS | identifierNone
case identifierLen >= 1 && identifierLen <= 2:
case identifierLen >= 1 && identifierLen <= identifier2ByteLength:
padding = strings.Repeat("\x00", identifier2ByteLength-identifierLen)
rl.protocol = urlProtocolHTTPS | identifier2Byte
case identifierLen >= 3 && identifierLen <= 8:
case identifierLen > identifier2ByteLength && identifierLen <= identifier8ByteLength:
padding = strings.Repeat("\x00", identifier8ByteLength-identifierLen)
rl.protocol = urlProtocolHTTPS | identifier8Byte
case identifierLen >= 9 && identifierLen <= 32:
case identifierLen > identifier8ByteLength && identifierLen <= identifier32ByteLength:
padding = strings.Repeat("\x00", identifier32ByteLength-identifierLen)
rl.protocol = urlProtocolHTTPS | identifier32Byte
default:
return fmt.Errorf("unsupported identifier length: %d", identifierLen)
}
rl.body = urlBody
rl.identifier = identifier
rl.identifier = identifier + padding
return nil
}
if strings.HasPrefix(lowerURL, kPrefixHTTP) {
Expand All @@ -309,13 +313,13 @@ func (rl *ResourceLocator) setURLWithIdentifier(url string, identifier string) e
switch {
case identifierLen == 0:
rl.protocol = urlProtocolHTTP | identifierNone
case identifierLen >= 1 && identifierLen <= identifier2ByteLength:
case identifierLen > 0 && identifierLen <= identifier2ByteLength:
padding = strings.Repeat("\x00", identifier2ByteLength-identifierLen)
rl.protocol = urlProtocolHTTP | identifier2Byte
case identifierLen >= 3 && identifierLen <= identifier8ByteLength:
case identifierLen > identifier2ByteLength && identifierLen <= identifier8ByteLength:
padding = strings.Repeat("\x00", identifier8ByteLength-identifierLen)
rl.protocol = urlProtocolHTTP | identifier8Byte
case identifierLen >= 9 && identifierLen <= identifier32ByteLength:
case identifierLen > identifier8ByteLength && identifierLen <= identifier32ByteLength:
padding = strings.Repeat("\x00", identifier32ByteLength-identifierLen)
rl.protocol = urlProtocolHTTP | identifier32Byte
default:
Expand Down
Loading