Skip to content

Conversation

@alkalescent
Copy link
Contributor

Proposed Changes

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@alkalescent alkalescent requested review from a team as code owners September 24, 2025 17:22
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the core identifier parsing capabilities by adding explicit support for FullyQualifiedObligation types. This enhancement allows the system to correctly interpret and handle these specific obligations, integrating them seamlessly into the existing identifier resolution framework. The change primarily involves updating the central Parse function to include a new case for this identifier type.

Highlights

  • New Identifier Type: Introduced support for parsing FullyQualifiedObligation identifiers within the core identifier parsing logic.
  • Parsing Logic Extension: The Parse function in policyidentifier.go has been updated to recognize and correctly process FullyQualifiedObligation types by calling the parseObligationFqn function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


New type takes its place, Parsing logic now expands, Code grows strong and clear.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be incomplete. While it adds a case for FullyQualifiedObligation in the Parse function, the FullyQualifiedObligation type itself and its parser function parseObligationFqn are not defined, which will lead to a compilation failure. Additionally, unit tests for this new functionality are missing, and the pull request description is empty. To proceed, please add the missing implementation, include corresponding unit tests to validate the changes, and update the description to provide context for reviewers.

@github-actions
Copy link
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 184.817765ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 101.452417ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 401.686901ms
Throughput 248.95 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.437364334s
Average Latency 371.238553ms
Throughput 133.56 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.644291912s
Average Latency 255.523946ms
Throughput 194.98 requests/second

@jakedoublev jakedoublev added this pull request to the merge queue Sep 24, 2025
Merged via the queue into main with commit 279bacd Sep 24, 2025
32 checks passed
@jakedoublev jakedoublev deleted the DSPX-1661-fqn2 branch September 24, 2025 18:47
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2025
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](lib/identifier/v0.1.0...lib/identifier/v0.2.0)
(2025-09-26)


### Features

* **core:** add FullyQualifiedObligation implementation
([#2761](#2761))
([279bacd](279bacd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants