Skip to content

feat(policy): Add validation to delete keys [backport to release/protocol/go/v0.6] #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

feat(policy): Add validation to delete keys [backport to release/protocol/go/v0.6] #2577

merged 1 commit into from
Jul 22, 2025

Conversation

@opentdf-automation
Copy link
Contributor

@opentdf-automation opentdf-automation bot commented Jul 22, 2025

Description

Backport of #2576 to release/protocol/go/v0.6.

@opentdf-automation opentdf-automation bot requested review from a team as code owners July 22, 2025 20:16
@opentdf-automation opentdf-automation bot mentioned this pull request Jul 22, 2025
Merged
3 tasks
@opentdf-automation
feat(policy): Add validation to delete keys (#2576)
5a5fae1 
### Proposed Changes

1.) Add necessary request parameters for validating that a user is
deleting the correct key.

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [ ] I have added or updated documentation

### Testing Instructions

(cherry picked from commit cc169d9)
@opentdf-automation opentdf-automation bot force-pushed the backport-2576-to-release/protocol/go/v0.6 branch from ac1dd0f to 5a5fae1 Compare July 22, 2025 20:16
@github-actions github-actions bot added comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) docs Documentation size/xs labels Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 175.359368ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 87.910491ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 352.434444ms
Throughput 283.74 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 38.536213288s
Average Latency 383.206702ms
Throughput 129.75 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 26.419118451s
Average Latency 263.204443ms
Throughput 189.26 requests/second

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 161.39873ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 103.369991ms

Standard Benchmark Metrics Skipped or Failed

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 545.024369ms
Throughput 183.48 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 37.09603967s
Average Latency 368.692486ms
Throughput 134.79 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 25.942347747s
Average Latency 258.672581ms
Throughput 192.74 requests/second

@c-r33d c-r33d merged commit f1f5819 into release/protocol/go/v0.6 Jul 22, 2025
41 of 43 checks passed
@c-r33d c-r33d deleted the backport-2576-to-release/protocol/go/v0.6 branch July 22, 2025 21:08
@opentdf-automation opentdf-automation bot mentioned this pull request Jul 22, 2025
Merged
c-r33d pushed a commit that referenced this pull request Jul 23, 2025
@opentdf-automation
chore(release): release protocol/go 0.6.2 (#2578)
15cfd48 
🤖 I have created a release *beep* *boop*
---


##
[0.6.2](protocol/go/v0.6.1...protocol/go/v0.6.2)
(2025-07-22)


### Features

* **policy:** Add validation to delete keys [backport to
release/protocol/go/v0.6]
([#2577](#2577))
([f1f5819](f1f5819))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strantalis strantalis strantalis approved these changes

@c-r33d c-r33d c-r33d approved these changes

Assignees

No one assigned

Labels

comp:policy Policy Configuration ( attributes, subject mappings, resource mappings, kas registry) docs Documentation size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strantalis @c-r33d