Skip to content

feat(attr value lookup by fqn): adds GetAttributesByFqns rpc in attributes service #243 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakedoublev merged 17 commits into from
Feb 23, 2024
Merged

feat(attr value lookup by fqn): adds GetAttributesByFqns rpc in attributes service #243 #250

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
117e2f2
add proto for GetAttributesByFqn and generate code
jakedoublev Feb 22, 2024
d47fa2c
clarify proto message name
jakedoublev Feb 22, 2024
2bb55c8
update readme list of attributes service with new rpc
jakedoublev Feb 22, 2024
5dcb62a
map fqns to attributes in a key/value dictionary returned in response…
jakedoublev Feb 22, 2024
7afd1e1
add db handler to get the attribute by FQN and build the response map
jakedoublev Feb 22, 2024
96edeac
integration tests
jakedoublev Feb 22, 2024
030fdb6
Merge branch 'main' into issue-243/fqn-lookup
jakedoublev Feb 22, 2024
193f64b
wip
jakedoublev Feb 22, 2024
d5a6a2d
update proto to reflect attribute lookup only by value which gives it…
jakedoublev Feb 23, 2024
19c26d1
remove foreign key namespace_id that does not exist on attribute_valu…
jakedoublev Feb 23, 2024
e6f3432
fix example to use /value/ in fqn like the rest of our implementation…
jakedoublev Feb 23, 2024
1914d11
Merge branch 'main' into issue-243/fqn-lookup
jakedoublev Feb 23, 2024
3e0fed8
checkpoint with working lookup of an attribute by value fqn
jakedoublev Feb 23, 2024
4cb3d89
add integration tests and update readme with new rpc name
jakedoublev Feb 23, 2024
2b7b62a
update api to provide back a map of the fqn to the entire attribute a…
jakedoublev Feb 23, 2024
f2e0f87
Merge branch 'main' into issue-243/fqn-lookup
jakedoublev Feb 23, 2024
6869e2b
Merge branch 'main' into issue-243/fqn-lookup
jakedoublev Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ This should bring up a grpc server on port **9000** and http server on port **80
policy.attributes.AttributesService.DeactivateAttributeValue
policy.attributes.AttributesService.GetAttribute
policy.attributes.AttributesService.GetAttributeValue
policy.attributes.AttributesService.GetAttributesByValueFqns
policy.attributes.AttributesService.ListAttributeValues
policy.attributes.AttributesService.ListAttributes
policy.attributes.AttributesService.RemoveKeyAccessServerFromAttribute
Expand Down
143 changes: 143 additions & 0 deletions docs/grpc/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,10 @@ <h2>Table of Contents</h2>
<a href="#policy.attributes.Attribute"><span class="badge">M</span>Attribute</a>
</li>

<li>
<a href="#policy.attributes.AttributeAndValue"><span class="badge">M</span>AttributeAndValue</a>
</li>

<li>
<a href="#policy.attributes.AttributeCreateUpdate"><span class="badge">M</span>AttributeCreateUpdate</a>
</li>
Expand Down Expand Up @@ -482,6 +486,18 @@ <h2>Table of Contents</h2>
<a href="#policy.attributes.GetAttributeValueResponse"><span class="badge">M</span>GetAttributeValueResponse</a>
</li>

<li>
<a href="#policy.attributes.GetAttributesByValueFqnsRequest"><span class="badge">M</span>GetAttributesByValueFqnsRequest</a>
</li>

<li>
<a href="#policy.attributes.GetAttributesByValueFqnsResponse"><span class="badge">M</span>GetAttributesByValueFqnsResponse</a>
</li>

<li>
<a href="#policy.attributes.GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry"><span class="badge">M</span>GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry</a>
</li>

<li>
<a href="#policy.attributes.ListAttributeValuesRequest"><span class="badge">M</span>ListAttributeValuesRequest</a>
</li>
Expand Down Expand Up @@ -2658,6 +2674,37 @@ <h3 id="policy.attributes.Attribute">Attribute</h3>



<h3 id="policy.attributes.AttributeAndValue">AttributeAndValue</h3>
<p></p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>attribute</td>
<td><a href="#policy.attributes.Attribute">Attribute</a></td>
<td></td>
<td><p> </p></td>
</tr>

<tr>
<td>value</td>
<td><a href="#policy.attributes.Value">Value</a></td>
<td></td>
<td><p> </p></td>
</tr>

</tbody>
</table>





<h3 id="policy.attributes.AttributeCreateUpdate">AttributeCreateUpdate</h3>
<p></p>

Expand Down Expand Up @@ -3036,6 +3083,85 @@ <h3 id="policy.attributes.GetAttributeValueResponse">GetAttributeValueResponse</



<h3 id="policy.attributes.GetAttributesByValueFqnsRequest">GetAttributesByValueFqnsRequest</h3>
<p></p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>fqns</td>
<td><a href="#string">string</a></td>
<td>repeated</td>
<td><p> </p></td>
</tr>

</tbody>
</table>





<h3 id="policy.attributes.GetAttributesByValueFqnsResponse">GetAttributesByValueFqnsResponse</h3>
<p></p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>fqn_attribute_values</td>
<td><a href="#policy.attributes.GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry">GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry</a></td>
<td>repeated</td>
<td><p>map of fqns to complete attributes and the one selected value </p></td>
</tr>

</tbody>
</table>





<h3 id="policy.attributes.GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry">GetAttributesByValueFqnsResponse.FqnAttributeValuesEntry</h3>
<p></p>


<table class="field-table">
<thead>
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
</thead>
<tbody>

<tr>
<td>key</td>
<td><a href="#string">string</a></td>
<td></td>
<td><p> </p></td>
</tr>

<tr>
<td>value</td>
<td><a href="#policy.attributes.AttributeAndValue">AttributeAndValue</a></td>
<td></td>
<td><p> </p></td>
</tr>

</tbody>
</table>





<h3 id="policy.attributes.ListAttributeValuesRequest">ListAttributeValuesRequest</h3>
<p></p>

Expand Down Expand Up @@ -3654,6 +3780,13 @@ <h3 id="policy.attributes.AttributesService">AttributesService</h3>
<td><p></p></td>
</tr>

<tr>
<td>GetAttributesByValueFqns</td>
<td><a href="#policy.attributes.GetAttributesByValueFqnsRequest">GetAttributesByValueFqnsRequest</a></td>
<td><a href="#policy.attributes.GetAttributesByValueFqnsResponse">GetAttributesByValueFqnsResponse</a></td>
<td><p></p></td>
</tr>

<tr>
<td>CreateAttribute</td>
<td><a href="#policy.attributes.CreateAttributeRequest">CreateAttributeRequest</a></td>
Expand Down Expand Up @@ -3843,6 +3976,16 @@ <h4>Methods with HTTP bindings</h4>



<tr>
<td>GetAttributesByValueFqns</td>
<td>GET</td>
<td>/attributes/_/fqn</td>
<td></td>
</tr>




<tr>
<td>CreateAttribute</td>
<td>POST</td>
Expand Down
57 changes: 57 additions & 0 deletions docs/openapi/policy/attributes/attributes.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,40 @@
]
}
},
"/attributes/_/fqn": {
"get": {
"operationId": "AttributesService_GetAttributesByValueFqns",
"responses": {
"200": {
"description": "A successful response.",
"schema": {
"$ref": "#/definitions/attributesGetAttributesByValueFqnsResponse"
}
},
"default": {
"description": "An unexpected error response.",
"schema": {
"$ref": "#/definitions/rpcStatus"
}
}
},
"parameters": [
{
"name": "fqns",
"in": "query",
"required": false,
"type": "array",
"items": {
"type": "string"
},
"collectionFormat": "multi"
}
],
"tags": [
"AttributesService"
]
}
},
"/attributes/_/values/{id}": {
"get": {
"summary": "* Attribute Value *",
Expand Down Expand Up @@ -484,6 +518,17 @@
}
}
},
"attributesAttributeAndValue": {
"type": "object",
"properties": {
"attribute": {
"$ref": "#/definitions/attributesAttribute"
},
"value": {
"$ref": "#/definitions/attributesValue"
}
}
},
"attributesAttributeCreateUpdate": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -583,6 +628,18 @@
}
}
},
"attributesGetAttributesByValueFqnsResponse": {
"type": "object",
"properties": {
"fqnAttributeValues": {
"type": "object",
"additionalProperties": {
"$ref": "#/definitions/attributesAttributeAndValue"
},
"title": "map of fqns to complete attributes and the one selected value"
}
}
},
"attributesListAttributeValuesResponse": {
"type": "object",
"properties": {
Expand Down
4 changes: 2 additions & 2 deletions examples/cmd/authorization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ func authorizationExamples(examplesConfig *ExampleConfig) error {
}}

// TODO Get attribute value ids
tradeSecretAttributeValueFqn := "https://namespace.com/attr/attr_name/val/replaceme"
openAttributeValueFqn := "https://open.io/attr/attr_name/val/open"
tradeSecretAttributeValueFqn := "https://namespace.com/attr/attr_name/value/replaceme"
openAttributeValueFqn := "https://open.io/attr/attr_name/value/open"

slog.Info("Getting decision for bob and alice for transmit action on resource set with trade secret and resource" +
" set with trade secret + open attribute values")
Expand Down
Loading