-
Notifications
You must be signed in to change notification settings - Fork 24
adr(docs): Decision around 2.0.5 sdk compatibility. #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| # Required | ||
| status: 'accepted' | ||
| date: '2025-06-16' | ||
| tags: | ||
| - sdk:v2.0.5 | ||
| - key management | ||
| # Optional | ||
| driver: '@strantalis @jrschumacher @c-r33d @damorris25' | ||
| deciders: '@strantalis @jrschumacher @c-r33d @damorris25' | ||
| consulted: '@strantalis @jrschumacher @c-r33d @damorris25' | ||
| informed: '@strantalis @jrschumacher @c-r33d @damorris25' | ||
| --- | ||
| # SDK backwards/forward compatibility v2.0.5 | ||
|
|
||
| ## Decision Outcome | ||
|
|
||
| 1. v2.0.5 of SDK should work with < v2.0.4 of platform | ||
| 2. < v2.0.5 of SDK should work with >= v2.0.5 of plaform | ||
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 3. We should not have a WithBaseKeyEnabled option, instead the platform version should be derived from the well-known. For v2.0.5 of the SDK we will prefer to use the base key if present and set properly. If it is not, we will fallback to using the default kases. In v2.0.6 the plan would be to error if the platform is >= v2.0.5 and the base key is not set. | ||
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 4. When creating a split plan if the SDK notices that there are key mappings it will **only** use those key mappings instead of grants. If no key mappings are present, the sdk will fallback to grants. | ||
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
c-r33d marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <!-- This is an optional element. Feel free to remove. --> | ||
| ### Consequences | ||
|
|
||
| - 🟩 **Good**, maintains backwards/forward compatibility | ||
| - 🟩 **Good**, allows us to not add another TDFOption | ||
strantalis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - 🟨 **Neutral**: Wellknown needs to be updated with platform version information. | ||
strantalis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - 🟨 **Neutral**: After an admin creates their first key mapping the SDK will ignore previously created grants. | ||
|
|
||
| <!-- This is an optional element. Feel free to remove. --> | ||
| ## Validation | ||
|
|
||
| - **Unit Tests:** SDK conditions for no base key functionality based on platform version | ||
| - **Integration Tests:** Mix of tests using new and old platform/sdk. *Should be covered in existing XTests* | ||
strantalis marked this conversation as resolved.
Show resolved
Hide resolved
strantalis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - **Manual Testing:** Deploy different versions of the SDK/Platform. | ||
| - **Documentation:** Update SDK and platform documentation to reflect the new configuration option and its usage. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.