Skip to content

feat(sdk): allow Connect-Protocol-Version RPC header for cors #2437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
+8 −1
Merged

feat(sdk): allow Connect-Protocol-Version RPC header for cors #2437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941b983
feat(sdk): allow Connect-Protocol-Version RPC header for cors
eugenioenko Jun 10, 2025
bb960e0
chore: update rest of configs and struct annotation
eugenioenko Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opentdf-core-mode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
# List of response headers that browsers are allowed to access
Expand Down
1 change: 1 addition & 0 deletions opentdf-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
- X-Request-ID
Expand Down
1 change: 1 addition & 0 deletions opentdf-ers-mode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
- X-Request-ID
Expand Down
2 changes: 2 additions & 0 deletions opentdf-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,10 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
- X-Request-ID
# List of response headers that browsers are allowed to access
exposedheaders:
- Link
Expand Down
1 change: 1 addition & 0 deletions opentdf-kas-mode.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
- X-Request-ID
Expand Down
2 changes: 1 addition & 1 deletion service/internal/server/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ type CORSConfig struct {
Enabled bool `mapstructure:"enabled" json:"enabled" default:"true"`
AllowedOrigins []string `mapstructure:"allowedorigins" json:"allowedorigins"`
AllowedMethods []string `mapstructure:"allowedmethods" json:"allowedmethods" default:"[\"GET\",\"POST\",\"PATCH\",\"DELETE\",\"OPTIONS\"]"`
AllowedHeaders []string `mapstructure:"allowedheaders" json:"allowedheaders" default:"[\"Accept\",\"Content-Type\",\"Content-Length\",\"Accept-Encoding\",\"X-CSRF-Token\",\"Authorization\",\"X-Requested-With\",\"Dpop\"]"`
AllowedHeaders []string `mapstructure:"allowedheaders" json:"allowedheaders" default:"[\"Accept\",\"Content-Type\",\"Content-Length\",\"Accept-Encoding\",\"X-CSRF-Token\",\"Authorization\",\"X-Requested-With\",\"Dpop\",\"Connect-Protocol-Version\"]"`
ExposedHeaders []string `mapstructure:"exposedheaders" json:"exposedheaders"`
AllowCredentials bool `mapstructure:"allowcredentials" json:"allowedcredentials" default:"true"`
MaxAge int `mapstructure:"maxage" json:"maxage" default:"3600"`
Expand Down
1 change: 1 addition & 0 deletions service/pkg/server/testdata/all-no-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ server:
allowedheaders:
- ACCEPT
- Authorization
- Connect-Protocol-Version
- Content-Type
- X-CSRF-Token
- X-Request-ID
Expand Down
Loading