Skip to content

Conversation

@b-long
Copy link
Contributor

@b-long b-long commented May 5, 2025

Proposed Changes

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 373.815615ms
Throughput 267.51 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 1m15.711213762s
Average Latency 754.736161ms
Throughput 66.04 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4949
Failed Requests 51
Concurrent Requests 50
Total Time 1m6.561814657s
Average Latency 661.755679ms
Throughput 74.35 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: rewrap failed: ocrypto.ComputeECDHKey failed :ocrypto.ECPubKeyFromPem failed: failed to parse PEM formatted public key 51 occurrences

Standard Benchmark Metrics Skipped or Failed

@b-long b-long force-pushed the chore/small-improvements-about-registration branch from 9e69e44 to 62ee901 Compare May 5, 2025 18:19
@b-long b-long marked this pull request as ready for review May 5, 2025 18:20
@b-long b-long requested a review from a team as a code owner May 5, 2025 18:20
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 363.754564ms
Throughput 274.91 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 1m17.343555016s
Average Latency 771.027964ms
Throughput 64.65 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4944
Failed Requests 56
Concurrent Requests 50
Total Time 1m7.892129667s
Average Latency 675.221481ms
Throughput 72.82 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: rewrap failed: ocrypto.ComputeECDHKey failed :ocrypto.ECPubKeyFromPem failed: failed to parse PEM formatted public key 56 occurrences

Standard Benchmark Metrics Skipped or Failed

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Benchmark results, click to expand

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 371.021669ms
Throughput 269.53 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 1m18.964796214s
Average Latency 787.30936ms
Throughput 63.32 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4957
Failed Requests 43
Concurrent Requests 50
Total Time 1m8.837376982s
Average Latency 685.490568ms
Throughput 72.01 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: rewrap failed: ocrypto.ComputeECDHKey failed :ocrypto.ECPubKeyFromPem failed: failed to parse PEM formatted public key 43 occurrences

Standard Benchmark Metrics Skipped or Failed

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2025

Benchmark results, click to expand

Benchmark Results:

Metric Value
Approved Decision Requests 5000
Denied Decision Requests 0
Total Time 458.729369ms

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 361.695009ms
Throughput 276.48 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 1m17.200415499s
Average Latency 768.920455ms
Throughput 64.77 requests/second

NANOTDF Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 4934
Failed Requests 66
Concurrent Requests 50
Total Time 1m7.161353617s
Average Latency 669.186671ms
Throughput 73.46 requests/second

Error Summary:

Error Message Occurrences
ReadNanoTDF error: rewrap failed: ocrypto.ComputeECDHKey failed :ocrypto.ECPubKeyFromPem failed: failed to parse PEM formatted public key 66 occurrences

Standard Benchmark Metrics Skipped or Failed

@strantalis strantalis added this pull request to the merge queue May 5, 2025
Merged via the queue into main with commit d7e8ec5 May 5, 2025
26 checks passed
@strantalis strantalis deleted the chore/small-improvements-about-registration branch May 5, 2025 21:50
jakedoublev pushed a commit that referenced this pull request May 6, 2025
### Proposed Changes

* Fix interface changes, relating to
#1715

### Checklist

- [ ] I have added or updated unit tests
- [ ] I have added or updated integration tests (if appropriate)
- [x] I have added or updated documentation

### Testing Instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants