Skip to content

ci(integration): Adds docker compose green test #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 16, 2024
Merged

ci(integration): Adds docker compose green test #211

merged 12 commits into from
Feb 16, 2024

Conversation

@dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Feb 16, 2024 •
edited
Loading

  • Uses the readme's suggested behavior to bring up the cluster and grpcurl it
  • GitHub action runners don't have a version of docker-compose that supports --wait, so I just threw in a sleep until it worked. LMK if I should write a waiter loop script

@dmihalcik-virtru dmihalcik-virtru marked this pull request as ready for review February 16, 2024 20:32
@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner February 16, 2024 20:32
jrschumacher
jrschumacher reviewed Feb 16, 2024
View reviewed changes
jakedoublev
jakedoublev reviewed Feb 16, 2024
View reviewed changes
@dmihalcik-virtru dmihalcik-virtru merged commit 642f804 into main Feb 16, 2024
@dmihalcik-virtru dmihalcik-virtru deleted the feature/compose-in-ci branch February 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrschumacher jrschumacher jrschumacher approved these changes

@jakedoublev jakedoublev jakedoublev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmihalcik-virtru @jrschumacher @jakedoublev