fix(sdk): reset reader after checking if IsNanoTDF #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strantalis
requested changes
Nov 5, 2024
Member
strantalis
left a comment
strantalis
left a comment
There was a problem hiding this comment.
Can you add a comment for IsValidNanoTDF. This way users will know we reset the reader for them.
strantalis
approved these changes
Nov 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.18](sdk/v0.3.17...sdk/v0.3.18) (2024-11-06) ### Bug Fixes * **core:** Autobump sdk ([#1725](#1725)) ([89e63de](89e63de)) * NanoTDF secure key from debug logging and iv conflict risk ([#1714](#1714)) ([7ba2e12](7ba2e12)) * **sdk:** Error message improvements ([#1176](#1176)) ([0ef65d4](0ef65d4)) * **sdk:** Fix handling of kas rewrap errors ([#1696](#1696)) ([ce10f3f](ce10f3f)) * **sdk:** reset reader after checking if IsNanoTDF ([#1718](#1718)) ([f9d6f26](f9d6f26)), closes [#1717](#1717) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1717