Skip to content

fix(policy): fix MatchSubjectMappings e2e functionality #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 29, 2024
Merged

fix(policy): fix MatchSubjectMappings e2e functionality #1692

merged 6 commits into from
Oct 29, 2024

Conversation

@jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Oct 29, 2024

  1. removes metadata from query
  2. ensures integration tests accurately test same JSONB stored by policy create/update APIs instead of fixtures (which differ in casing as snake_case instead of camelCase when marshaled by protojson)
  3. ensures value field is not required on SubjectProperty message which is not needed by this API

@jakedoublev jakedoublev requested a review from a team as a code owner October 29, 2024 18:29
@jakedoublev jakedoublev merged commit b7c4788 into feature/matchsubjectmappings Oct 29, 2024
15 checks passed
@jakedoublev jakedoublev deleted the feature/matchsubjectmappings-fix branch October 29, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alkalescent alkalescent alkalescent approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakedoublev @alkalescent