Skip to content

feat(core): add RPCs to namespaces service to handle assignment/removal of KAS grants #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrschumacher merged 2 commits into from
Aug 14, 2024
Merged

feat(core): add RPCs to namespaces service to handle assignment/removal of KAS grants #1344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f915f40
feat(core): add RPCs to namespaces service to handle assignment/remov…
jakedoublev Aug 13, 2024
eab367c
do not make pointer receiver vs value receiver distinction in this PR
jakedoublev Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions service/logger/audit/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ const (
ObjectTypeNamespace
ObjectTypeConditionSet
ObjectTypeKasRegistry
ObjectTypeKasAttributeNamespaceAssignment
ObjectTypeKasAttributeDefinitionAssignment
ObjectTypeKasAttributeValueAssignment
ObjectTypeKeyObject
Expand All @@ -29,6 +30,7 @@ func (ot ObjectType) String() string {
"namespace",
"condition_set",
"kas_registry",
"kas_attribute_namespace_assignment",
"kas_attribute_definition_assignment",
"kas_attribute_value_assignment",
"key_object",
Expand Down
40 changes: 40 additions & 0 deletions service/policy/namespaces/namespaces.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,43 @@ func (ns NamespacesService) DeactivateNamespace(ctx context.Context, req *namesp

return rsp, nil
}

func (ns NamespacesService) AssignKeyAccessServerToNamespace(ctx context.Context, req *namespaces.AssignKeyAccessServerToNamespaceRequest) (*namespaces.AssignKeyAccessServerToNamespaceResponse, error) {
grant := req.GetNamespaceKeyAccessServer()
auditParams := audit.PolicyEventParams{
ActionType: audit.ActionTypeCreate,
ObjectType: audit.ObjectTypeKasAttributeNamespaceAssignment,
ObjectID: fmt.Sprintf("%s-%s", grant.GetNamespaceId(), grant.GetKeyAccessServerId()),
}

namespaceKas, err := ns.dbClient.AssignKeyAccessServerToNamespace(ctx, grant)
if err != nil {
ns.logger.Audit.PolicyCRUDFailure(ctx, auditParams)
return nil, db.StatusifyError(err, db.ErrTextCreationFailed, slog.String("namespaceKas", grant.String()))
}
ns.logger.Audit.PolicyCRUDSuccess(ctx, auditParams)

return &namespaces.AssignKeyAccessServerToNamespaceResponse{
NamespaceKeyAccessServer: namespaceKas,
}, nil
}

func (ns NamespacesService) RemoveKeyAccessServerFromNamespace(ctx context.Context, req *namespaces.RemoveKeyAccessServerFromNamespaceRequest) (*namespaces.RemoveKeyAccessServerFromNamespaceResponse, error) {
grant := req.GetNamespaceKeyAccessServer()
auditParams := audit.PolicyEventParams{
ActionType: audit.ActionTypeDelete,
ObjectType: audit.ObjectTypeKasAttributeNamespaceAssignment,
ObjectID: fmt.Sprintf("%s-%s", grant.GetNamespaceId(), grant.GetKeyAccessServerId()),
}

namespaceKas, err := ns.dbClient.RemoveKeyAccessServerFromNamespace(ctx, grant)
if err != nil {
ns.logger.Audit.PolicyCRUDFailure(ctx, auditParams)
return nil, db.StatusifyError(err, db.ErrTextDeletionFailed, slog.String("namespaceKas", grant.String()))
}
ns.logger.Audit.PolicyCRUDSuccess(ctx, auditParams)

return &namespaces.RemoveKeyAccessServerFromNamespaceResponse{
NamespaceKeyAccessServer: namespaceKas,
}, nil
}