chore(issue 74): attribute values integration test suite #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
commented
Jan 30, 2024
jakedoublev
commented
Jan 30, 2024
…st of attr values to match proto expectation
jakedoublev
commented
Feb 1, 2024
| metadata []byte) (string, []interface{}, error) { | ||
| sb := newStatementBuilder(). | ||
| Update(AttributeValueTable) | ||
| Update(AttributeValueTable). |
Contributor
Author
There was a problem hiding this comment.
I'm not sure why, but without this change our metadata was not being successfully updated.
Member
There was a problem hiding this comment.
Oh, that makes sense, I left off the sb = sb.Set("metadata", metadata) on line 173 so when we generate the SQL it lacked the metadata update because Go passes by value.
jrschumacher
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #74