Skip to content

refactor(PLAT-2983): store dialOptions as a list #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmihalcik-virtru wants to merge 1 commit into from
Closed

refactor(PLAT-2983): store dialOptions as a list #106

dmihalcik-virtru wants to merge 1 commit into from

Conversation

@dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Jan 30, 2024 •
edited
Loading

  • This will allow us to reconfigure grpc configuration in the options objects, instead of the constructor

@dmihalcik-virtru dmihalcik-virtru requested a review from a team as a code owner January 30, 2024 21:28
@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/sdk-api-refactor branch 2 times, most recently from 524d34b to 125be76 Compare February 5, 2024 20:49
@dmihalcik-virtru dmihalcik-virtru changed the title 🚧 SDK Refactor feat(PLAT-2983): SDK Refactor (New function) Feb 5, 2024
@dmihalcik-virtru dmihalcik-virtru changed the title feat(PLAT-2983): SDK Refactor (New function) feat(PLAT-2983): SDK Refactor: sdk.New Feb 5, 2024
strantalis
strantalis reviewed Feb 6, 2024
View reviewed changes
@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/sdk-api-refactor branch from e0e0d39 to 92f5c23 Compare February 6, 2024 19:21
@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/sdk-api-refactor branch 4 times, most recently from c9eb7af to d292203 Compare February 13, 2024 18:51
@dmihalcik-virtru dmihalcik-virtru changed the title feat(PLAT-2983): SDK Refactor: sdk.New refactor(PLAT-2983): save dialConfig as a list Feb 13, 2024
@dmihalcik-virtru dmihalcik-virtru changed the title refactor(PLAT-2983): save dialConfig as a list refactor(PLAT-2983): store dialOptions as a list Feb 13, 2024
@dmihalcik-virtru
refactor(PLAT-2983): minor dialOptions refactor
3dd2c38 
- instead of listing explicit dial options, keep them as a list
@dmihalcik-virtru
Copy link
Member Author

dmihalcik-virtru commented Feb 29, 2024

This was mostly added in #271

@dmihalcik-virtru dmihalcik-virtru deleted the feature/sdk-api-refactor branch March 8, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strantalis strantalis Awaiting requested review from strantalis

@sujankota sujankota Awaiting requested review from sujankota

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmihalcik-virtru @strantalis