chore(Issue 78): integration tests for key_access_server registry db interactions #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic key locations
jakedoublev
commented
Jan 30, 2024
| common.MetadataMutable metadata = 1; | ||
|
|
||
| string name = 2 [(buf.validate.field).required = true]; | ||
| string key_access_server = 2 [(buf.validate.field).required = true]; |
Contributor
Author
There was a problem hiding this comment.
Is key_access_server the best name for this field, or could we use one more descriptive like uri, location, or address for this proto field and DB column name since my understanding is it's the address of the running KAS? Is there a case where name/key_access_server/tbd_column_name is not pointing to a server address?
Member
There was a problem hiding this comment.
Yea, I think uri makes a lot of sense. Although I would not validate the URI at this time.
Contributor
Author
There was a problem hiding this comment.
Shall I proceed with that value, or is there additional input we need to move forward with the decision?
…er to uri and update protos, db, sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #78