feat(core): kas-grants CRUD #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

alkalescent merged 14 commits into main from feature/kas-grants

Mar 27, 2024

Contributor

alkalescent commented Mar 26, 2024

No description provided.

alkalescent added 7 commits

March 26, 2024 16:43


          add kas-grants handlers

cb13ce5


          boilerplate cmd

ca3af38


          update flags

a593fe7


          clean up

67df0fa


          update cmd

753f4c5


          clean up

656b697


          delete cmd

00ed368

alkalescent changed the title ~~feature(cli): kas-grants CRUD~~ feat(cli): kas-grants CRUD

alkalescent changed the title ~~feat(cli): kas-grants CRUD~~ feat(core): kas-grants CRUD

jakedoublev reviewed

View reviewed changes

pkg/handlers/kas-grants.go Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

jakedoublev reviewed

View reviewed changes

cmd/kas-grants.go Outdated Show resolved Hide resolved

Contributor

jakedoublev commented Mar 27, 2024 •

edited

Loading

Great work, @suchak1. Above are some questions, some optional nit picks, and some suggestions. The nit picks are prefaced by Nit: for clarity. Let me know if you'd like to discuss anything.

alkalescent and others added 7 commits

March 27, 2024 11:19


          Update cmd/kas-grants.go

933ffb6

Co-authored-by: Jake Van Vorhis <[email protected]>


          delete check

769ce26


          Update cmd/kas-grants.go

2a13876

Co-authored-by: Jake Van Vorhis <[email protected]>


          Update cmd/kas-grants.go

Co-authored-by: Jake Van Vorhis <[email protected]>


          Update cmd/kas-grants.go

e7d838a

Co-authored-by: Jake Van Vorhis <[email protected]>


          flag labels

21038ca


          pass response to HandleSuccess

2747c45

jakedoublev approved these changes

View reviewed changes

alkalescent merged commit f53b61d into main

alkalescent deleted the feature/kas-grants branch

March 27, 2024 15:38

alkalescent linked an issue

that may be closed by this pull request

Add CLI kas-grants CRUD commands #36

Closed

opentdf-automation bot mentioned this pull request

chore(main): release 0.21.0 #577

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet