-
Notifications
You must be signed in to change notification settings - Fork 6
feat(core): DSPX-896 add registered resources CRUD #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
LanguageTool
[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS
| ```shell |
[LanguageTool] reported by reviewdog 🐶
This abbreviation for “identification” is spelled all-uppercase. (ID_CASING[2])
Suggestions: ID
Rule: https://community.languagetool.org/rule/show/ID_CASING?lang=en-US&subId=2
Category: CASING
| - name: id |
[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: Peps, PEPS, Pets, EPs, Peas, Pens, Pepsi, Pegs, Pep, Pews, Pops, Pups, Pepe, Pepys, Pips, Reps, Peeps, Preps, CEPS, EPS, IEPs, MEPs, PAPS, PENS, PEP, PES, PPEs, PPS, SEPs, Deps, Paps, Pecs, Pees, Yeps, Yes, Less, Kept, News, Pass, Gets, Peak, Plus, Pop, Press, Sees, Sets, Jews, Pope, Fees, Helps, Legs, Maps, Opens, Poems, Steps, Beds, Caps, Keeps, Keys, Laps, Lens, Pays, Peaks, Peer, Peers, Pen, Per, Pet, Pipe, Pipes, Poets, Puts, Seas, Tens, Ups, GPS, PCs, POWs, Penn, Peru, Pete, Bees, Cups, Gaps, Jets, Lets, Lips, Mess, Nets, Pads, Piers, Pigs, Pins, Pits, Props, Pubs, Pumps, Tips, Tops, Alps, LEDs, LPs, PDP, PET, PPP, PSP, Peel, Pius, Sept, Zeus, Apes, Begs, Bets, Cops, Eds, Gems, Hers, Hips, Hops, Leaps, Pans, Pas, Pear, Peso, Pesos, Pest, Pests, Pies, Pleas, Pods, Popes, Pots, Ppm, Prep, APS, Bess, EPP, Hess, IPS, Jens, Jess, MIPS, NPS, PCBs, PCP, PDS, PNP, PPD, PPI, PRS, Peck, Perl, Peña, Phelps, Rep, Tess, UPS, Amps, Dens, Dips, Eels, Fess, Heaps, Hens, Ops, Paws, Pea, Pears, Peg, Pelts, Pros, Puns, Raps, Reds, Rips, Taps, Teas, Webs, Wept, CEP, EPG, ESS, IEP, NEP, PACs, PFP, PKP, PMS, PNS, PSS, Pecos, Perm, PhDs, SNPs, USPS, VIPs, Fens, Gels, Jeeps, Kegs, Pals, Pars, Peal, Peat, Peek, Peels, Peep, Pelt, Pent, Perks, Pew, Pimps, Pip, Ppb, Preys, Pts, Pulps, Pup, Pupa, Pus, Seeps, Specs, Tees, Temps, Vets, Weeps, Debs, EPL, ERS, HEPA, MVPs, PDFs, PEO, PLCs, PVS, Pele, Pena, Pres, Beeps, Beys, Dept, Fps, Imps, Kepi, Lees, Pap, Papa, Pats, Peeks, Pepsin, Plebs, Repo, Revs, Secs, Weds, Wets, DPs, DSPs, EPF, NeWS, Bps, Deeps, Feds, Gens, Hems, Hep, Kepis, Leis, Mews, Mops, Naps, Peals, Pecks, Peen, Peons, Peppy, Perk, Pics, Reaps, Refs, Saps, Sews, Sips, Spews, Yelps, Yews, Yips, Zaps, Zips, Leos, Lepus, Mbps, PMs, Apps, Hews, Meds, Nips, Oops, Papas, Peon, Perms, Pert, Phys, Pols, Pugs, Puss, Repos, Yeas, Asps, Bops, Ems, Fops, Lops, Pends, Poss, Rems, Sops, Sups, Yaps, Yep, FEMS, MPs, PS, Gees, Gyps, Kips, Leas, Megs, Neaps, Peke, Pend, Plops, Rps, Umps, Wens, Épées, REMs, Xes, Zens, Ftps, Pelf, Ppr, Teds, Yens, AEP, AES, AFPS, ANPS, APs, BECS, BEP, BES, BPJEPS, BPS, CEMS, CEOs, CEPA, CES, CESS, CNPS, CPPS, CPS, CREPS, CSPS, CoPs, DECs, DEP, DES, DHEPS, DPS, Dems, Depp, EAS, EBS, ECS, EDS, EEP, EFS, EHS, EIS, ELS, ENS, EOPS, EP, EPA, EPI, EPM, EPO, EPOS, EPR, EPSF, EPSI, EPSM, EPT, EPU, EPV, ERPs, ES, ETS, EUS, EVS, EVs, EWS, EXS, EZS, Es, FENS, FEP, FES, FEVS, FIPS, FPS, FPs, GDPs, GES, GRPS, HDPS, HES, HPS, IDPs, IERS, IES, IPs, ISPS, ISPs, JPEGs, Japs, KES, LEP, LES, LIPS, LPS, Les, MCPS, MEP, MEPA, MERS, MES, MFPs, MPS, Mets, NTPs, OEMs, OEP, OEPA, OPEP, P&P, P2P, PAAs, PACS, PAES, PAP, PAS, PAs, PBIS, PBS, PCS, PCUS, PDMS, PE, PEA, PEB, PEC, PED, PEE, PEF, PEGC, PEI, PEK, PEL, PEM, PEN, PEOC, PER, PERL, PERP, PERT, PESC, PETA, PEV, PFS, PGP, PGS, PHP, PHS, PIDs, PIGS, PIP, PIPA, PIS, PKGs, PKS, PLP, PLS, PMP, PNGs, PNNS, POCs, POP, POS, POVs, PP, PP1, PP2, PP3, PP4, PP7, PPA, PPB, PPC, PPDS, PPE, PPH, PPK, PPL, PPM, PPN, PPO, PPQ, PPR, PPT, PPTs, PPU, PPV, PQP, PRAS, PRP, PRPO, PRs, PTP, PUAS, PUP, PUPD, PUS, PVP, PWAs, PZPR, PaaS, Pei, Pelé, Peng, Pepin, Perls, Perú, PoCs, PoWs, REP, RERS, RES, RFPs, RPS, SDPS, SEAS, SEP, SEPA, SERPs, SES, SNEPS, SOPs, SPS, SVPs, Sep, TDPS, TECS, TEP, TES, TESS, TEUs, TPS, UDPS, UES, VES, VPS, VPs, WPS, XPS, ZEP, Baps, Cps, Dep, Devs, Ens, Epees, Greps, Hes, Kens, Mes, pHs, Pcs, Pee, Peed, Peens, Pekes, Penis, Perv, Pervs, Pgs, Phis, Pis, Piss, Pls, Pms, Poms, Pons, Poops, Poos, Pp, Ppl, Psis, Puds, Pwns, Père, Res, Sens, Veeps, Wees, Yups, Zeds, EQS, IOPS, PECL, PyPI, REPL
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS
| If PEPs rely on this value, a value update could break access. |
[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS
| For more information about Registered Resource Values, see the manual for the `values` subcommand. |
[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS
| ```shell |
jakedoublev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great so far.
…e test for action attr values
jentfoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🤖 I have created a release *beep* *boop* --- ## [0.21.0](v0.20.0...v0.21.0) (2025-05-29) ### Features * Add initial Dependency Review configuration ([#551](#551)) ([b622666](b622666)) * **core:** Add base key cmds ([#563](#563)) ([edfd6c0](edfd6c0)) * **core:** DSPX-18 clean up Go context usage to follow best practices ([#558](#558)) ([a2c9f8b](a2c9f8b)) * **core:** DSPX-608 - Deprecate public_client_id ([#555](#555)) ([8d396bd](8d396bd)) * **core:** DSPX-608 - require clientID for login ([#553](#553)) ([580172e](580172e)) * **core:** DSPX-896 add registered resources CRUD ([#559](#559)) ([8e7475e](8e7475e)) * **core:** KAS allowlist options ([#539](#539)) ([af7978f](af7978f)) * **core:** key management operations ([#533](#533)) ([d4f6aaa](d4f6aaa)) * **main:** add actions CRUD and e2e tests ([#523](#523)) ([2fb9ec7](2fb9ec7)) * **main:** refactor actions within existing CLI policy object CRUD ([#543](#543)) ([9ab1a58](9ab1a58)) * **core:** Resource mapping groups ([#567](#567)) ([03fa307](03fa307)) * **core:** Update key mgmt flags to consistent format ([#570](#570)) ([#846f96c](846f96c)) * **core:** Rotate Key ([#572](#572)) ([afd0043](afd0043)) ### Bug Fixes * **ci:** ci job should run on changes to GHA ([#530](#530)) ([1d296ca](1d296ca)) * **main:** Pass the full url when building the sdk object ([#544](#544)) ([8b836f0](8b836f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com> Co-authored-by: Elizabeth Healy <[email protected]> Co-authored-by: Chris Reed <[email protected]> Co-authored-by: Jake Van Vorhis <[email protected]>
Adds CLI support for registered resources CRUD, including action attribute values as well