feat(core): pagination of LIST commands #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ryanulit
requested changes
Dec 5, 2024
Contributor
ryanulit
left a comment
ryanulit
left a comment
There was a problem hiding this comment.
Looks good, but just some questions about context usage...
ryanulit
approved these changes
Dec 5, 2024
jakedoublev
pushed a commit
that referenced
this pull request
Dec 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.0...v0.17.0) (2024-12-05) ### Features * **core:** pagination of LIST commands ([#447](#447)) ([673a064](673a064)) * **core:** subject condition set prune ([#439](#439)) ([c4c8b8b](c4c8b8b)) ### Bug Fixes * **core:** kas registry get should allow -i 'id' flag shorthand ([#434](#434)) ([bed3701](bed3701)) * **core:** sm list should provide value fqn instead of just value string ([#438](#438)) ([9a7cb72](9a7cb72)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--regexpwith the wrong values but passed because of more generousassert_outputinstead ofassert_lineattributesalone to avoid test redundancy