feat(core): update to use the new sdk wrapper #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrschumacher
force-pushed
the
jrschumacher/issue8
branch
from
f47d3de to
6d636a3
Compare
jrschumacher
changed the title
jakedoublev
previously approved these changes
Jan 17, 2024
Contributor
jakedoublev
left a comment
jakedoublev
left a comment
There was a problem hiding this comment.
I know the SDK work isn't quite landed, but approving this now to merge in when it is.
jakedoublev
approved these changes
Jan 17, 2024
jakedoublev
reviewed
Jan 17, 2024
| Run: func(cmd *cobra.Command, args []string) { | ||
| close := cli.GrpcConnect(cmd) | ||
| defer close() | ||
| h := cli.NewHandler(cmd) |
Contributor
There was a problem hiding this comment.
I like this abstraction of grpc as the API mechanism away from the CLI commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.