Filter biobliography results by publication date #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update minDate to use no limit query
JarrodBaker
suggested changes
Jul 7, 2022
There was a problem hiding this comment.
Just a small change about Option. Otherwise it's looking really good. I'd like us to try and get some unit testing around this. Let's discuss next Thursday how we can test this to a) have some tests as documentation and b) make sure we don't introduce any regressions in future when we work in this part of the code.
There does not seem to be any advantage to use two queries to get the total number of publications and the earliest publication date.
add null folder to gitignore
reformat files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update total to include date filter
update minDate to use no limit query