Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

handle phase 5 non-status evidence in drug collapse #200

Merged
merged 2 commits into from
Sep 11, 2019

Conversation

afaulconbridge
Copy link
Contributor

As described opentargets/issues#682 (comment) the drug evidence collapse was inadvertently omitting evidence with phase V and without a status.

I've re-structured the Elasticsearch JSON query to allow for this, using a series of nested aggregations instead of a composite one.

@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #200 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   19.39%   19.23%   -0.16%     
==========================================
  Files          33       33              
  Lines        3089     3114      +25     
==========================================
  Hits          599      599              
- Misses       2490     2515      +25
Impacted Files Coverage Δ
app/common/elasticsearchclient.py 14.6% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa0a05...642dba8. Read the comment docs.

@cmalangone cmalangone merged commit 8a08a4c into master Sep 11, 2019
@cmalangone cmalangone deleted the af-drug-evidence-collapse-phase-5 branch September 11, 2019 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants