Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bicycle_foot: Reference locationSet.exclude from crossing preset #1204

Closed
wants to merge 1 commit into from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Apr 28, 2024

https://github.com/openstreetmap/id-tagging-schema/pull/1193/files#diff-3b8f616654b5d2845f63eb05ce32b27741d3945ad0a71e55033de12a656d8b56R7 highlighted that location list for the bicycle_foot preset and the bicycle_foot crossing preset are out of sync.

The issue is: de is missing in the crossing preset.

This PRs tests if the schema builder does support to reference the excludes. It does not say so explicitly in https://github.com/ideditor/schema-builder?tab=readme-ov-file#locationset, so if this works the docs need an update as well.

PS: The validation npm run build does not show any issues.

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator Author

tordans commented Apr 28, 2024

Testing

This does not work. I still see the preset when testing in Germany which should be part of the exclude list.

image

I will create a feature request on the schema builder next: ideditor/schema-builder#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant