Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt capacity tags for camp sites etc. #107

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Conversation

jonsger
Copy link
Contributor

@jonsger jonsger commented Jan 9, 2021

Recently there was an improvement to the capacity tagging for camp sites.

capacity got replaced by capacity:caravans, capacity:persons and capacity:tents. So this PR adapt to that.

What do you think?

Copy link
Collaborator

@mbrzakovic mbrzakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is reasonable given that capacity tag is indeed ambiguous in these cases.
I observed the wiki-page that is inline with this statement https://wiki.openstreetmap.org/wiki/Key:capacity

source_strings.yaml should be updated, thought I don't consider this a pr blocker (usually this is done via: npm run build)

Additionally, it would be great if wiki pages for new fields could be created, so the field info in iD can link back to appropriate information.

data/presets/tourism/camp_site.json Outdated Show resolved Hide resolved
@tyrasd tyrasd added new-field enhancement New feature or request labels Dec 14, 2021
@tyrasd tyrasd merged commit 1ce208b into openstreetmap:main Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new-field
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants