Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golf=bunker should use surface #534

Closed
DaveF63 opened this issue Jul 14, 2022 · 10 comments
Closed

golf=bunker should use surface #534

DaveF63 opened this issue Jul 14, 2022 · 10 comments
Labels
bug Something isn't working

Comments

@DaveF63
Copy link

DaveF63 commented Jul 14, 2022

Given it's been agreed in #203 that other golf features use the surface tag to indicate their, err... surface, it appears illogical to auto add natural=sand to golf=bunker.

natural=* is a primary tag, designed to be used in isolation, not a supplementary, sub/adjective tag.

Oh, and not all bunkers are sand.

@tyrasd tyrasd added the bug Something isn't working label Jul 15, 2022
@tyrasd
Copy link
Member

tyrasd commented Jul 15, 2022

Earlier this year, the wiki still recommended natural=sand (or surface=sand), but I agree that surface would do a better job at it.

not all bunkers are sand.

Oh, really? What other types of bunkers exist? FWIW, at least the USGA considers bunkers to be a term specific for sandy obstacles:

Bunkers […] are specially prepared areas intended to test the player’s ability to play a ball from the sand.

@matkoniecz
Copy link
Contributor

natural=* is a primary tag, designed to be used in isolation, not a supplementary, sub/adjective tag.

in some cases multiple primary tags may apply (though in this case using surface is not making things worse)

BTW, #409 appears to request exact opposite

@DaveF63
Copy link
Author

DaveF63 commented Jul 15, 2022

Oh, really? What other types of bunkers exist?

https://www.golfcompendium.com/2019/10/grass-bunker.html
https://golf.com/travel/ways-architects-use-grass-hazards

Admittedly, they're much rarer, but they do exist, even in the US.

@tyrasd
Copy link
Member

tyrasd commented Jul 15, 2022

Hm… these things should probably be mapped as golf=rough instead of golf=bunker, as they are not actually bunkers:

Important note: Grass bunkers are not, technically, bunkers at all under the Rules of Golf. […] A grass bunker, therefore, is treated as just any other grassed area of a golf course, any other patch of rough.

@tyrasd tyrasd closed this as completed in adea4db Jul 15, 2022
@DaveF63
Copy link
Author

DaveF63 commented Jul 15, 2022

in some cases multiple primary tags may apply

Disagree.
Primary: "First in a group or series.", "placed ahead of others."

Do you have any OSM examples?

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 15, 2022

Do you have any OSM examples?

amenity = drinking_water
man_made = water_tap
amenity = place_of_worship
man_made = cross
amenity = place_of_worship
building = chapel
amenity = shelter
building = yes
amenity = drinking_water
man_made = drinking_fountain

@DaveF63
Copy link
Author

DaveF63 commented Jul 17, 2022

?!?

I'll discuss these on another forum as this one is inappropriate.

amenity = drinking_water
man_made = water_tap

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 17, 2022

Feel free to ping me here or via mail if that is not tagging mailing list or OSM wiki with ping template being used.

And this combination is perfectly fine.

@DaveF63
Copy link
Author

DaveF63 commented Jul 17, 2022

Oh, really? What other types of bunkers exist? FWIW, at least the USGA considers bunkers to be a term specific for sandy obstacles:

What you're actually quoting is The R&A. (I believe they're on the telly at the moment). Their concern is with the likes of competition courses.

Around the world there are hundreds of smaller courses, municipal run pitch 'n' putt etc which can have grass covered craters to reduce maintenance costs.

@DaveF63
Copy link
Author

DaveF63 commented Jul 17, 2022

To check, are there any other tags prescribing natural-sand or is this swap purely golf=bunker?

https://taghistory.raifer.tech/#***/natural/sand&***/surface/sand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants