Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golf presets recommend landuse over surface #203

Closed
Zaneo opened this issue Jul 28, 2021 · 5 comments
Closed

Golf presets recommend landuse over surface #203

Zaneo opened this issue Jul 28, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@Zaneo
Copy link

Zaneo commented Jul 28, 2021

While the wiki is not authoritative, it does explicitly say not to use landuse=grass for putting green, fairway, rough.
Currently right now it seems iD is recommending this for such items. Should this be changed within iD?

@Adamant36
Copy link

I think it's based on the fact that it's currently how they overwhelming mapped. Which, unfortunately, will likely continue to be the case until the main style renders golf related features. Luckily there's an open PR that would fix the issue (Update leisure=golf_course color and render golf=* features (gravitystorm/openstreetmap-carto#4381), but who knows when or if it will be merged. That's the best way to get this resolved though.

@DaveF63
Copy link

DaveF63 commented Jul 14, 2022

To check is 'iD 0328e10' classed as the latest version of iD?
https://preview.ideditor.com/master/

https://www.openstreetmap.org/changeset/122993096
As it's put this in the changeset meta data, it appears to still be recommending changing to the landuse key:
"resolved:outdated_tags:incomplete_tags" = 58

https://osmlab.github.io/changeset-map/#122993096

@tyrasd
Copy link
Member

tyrasd commented Jul 15, 2022

created_by iD 0328e10
host https://preview.ideditor.com/master/

Unfortunately, the user is mapping using the unreleased v3-prototype version of iD which comes with an outdated presets dataset. I can't do too much to fix this at the moment because the domain and server where the prototype is hosted is not something I have access to. At least the domain is currently still owned by mapbox: I had talked to @mikelmaron a few weeks ago about the possibility to transfer the domain to the OSMF. It wasn't high priority task when we discussed it… but maybe it should be addressed rather sooner than later, so we can address issue like this one.

@DaveF63
Copy link

DaveF63 commented Jul 17, 2022

unreleased v3-prototype version of iD which comes with an outdated presets dataset.

How many forks/betas are there 'out in the wild'?

Shouldn't new test software being using the latest data sets?
To prevent this, could future development programs reference the 'in use' data, even if they're on different servers?

@tyrasd
Copy link
Member

tyrasd commented Jul 18, 2022

How many forks/betas are there 'out in the wild'?

Hard to tell. There is https://preview.ideditor.com/master/, and there is at least one more developed by a group in Canada who are now starting to backport their modifications into the current development version of iD.

Shouldn't new test software being using the latest data sets?

They should, but there is no way to enforce this. Everyone is free to use whatever presets they want.

To prevent this, could future development programs reference the 'in use' data, even if their on different servers?

This is how it is currently implemented, but forks based on older states of the software might not have that feature. Also note that there might come a point where the presets database has a major version bump (e.g. in order to support more complex deprecation rules – ideditor/schema-builder#62) of the presets database. That would again require all consumers (forks) to upgrade their code base in order to be able to consume the newest presets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants